]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: clear GOPROXY in TestGoGetInsecure
authorBryan C. Mills <bcmills@google.com>
Tue, 5 Mar 2019 22:01:19 +0000 (17:01 -0500)
committerBryan C. Mills <bcmills@google.com>
Wed, 6 Mar 2019 19:57:31 +0000 (19:57 +0000)
TestGoGetInsecure verifies that 'go get -insecure' can fetch a
particular package. However, the GOPROXY protocol does not provide a
means for proxies to indicate packages as insecure; thus, proxies
cannot safely serve those packages.

Updates #30571

Change-Id: I447776dff98bd8ee6eb5055b897b9c7d293e3423
Reviewed-on: https://go-review.googlesource.com/c/go/+/165745
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/go_test.go

index 9ba52e609e1ef67492a522df20fd267586224f85..c6fb046b320f1cf1410a12e472cd3b2d5b4a3e9a 100644 (file)
@@ -3670,6 +3670,7 @@ func TestGoGetInsecure(t *testing.T) {
                        tg.tempFile("go.mod", "module m")
                        tg.cd(tg.path("."))
                        tg.setenv("GO111MODULE", "on")
+                       tg.setenv("GO111PROXY", "")
                } else {
                        tg.setenv("GOPATH", tg.path("."))
                        tg.setenv("GO111MODULE", "off")