]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.23]time: accept "+01" in TestLoadFixed on OpenBSD
authorDmitri Shuralyov <dmitshur@golang.org>
Mon, 4 Nov 2024 22:36:26 +0000 (17:36 -0500)
committerGopher Robot <gobot@golang.org>
Tue, 19 Nov 2024 18:04:02 +0000 (18:04 +0000)
This stops the test from failing with a known failure mode, and
creates time to look into what the next steps should be, if any.

For #69840
Fixes #70239

Change-Id: I060903d256ed65c5dfcd70ae76eb361cab63186f
Reviewed-on: https://go-review.googlesource.com/c/go/+/625197
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Eric Grosse <grosse@gmail.com>
(cherry picked from commit bea9b91f0f4be730c880edbe496ab25c9b742cad)
Reviewed-on: https://go-review.googlesource.com/c/go/+/627575
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>

src/time/time_test.go

index 70eb61478480e0f445aa1e6dfd4c959925feccde..c12b9117d0f5c17109bb9764a95948dddf813a5c 100644 (file)
@@ -14,6 +14,7 @@ import (
        "math/rand"
        "os"
        "runtime"
+       "slices"
        "strings"
        "sync"
        "testing"
@@ -1084,10 +1085,15 @@ func TestLoadFixed(t *testing.T) {
        // So GMT+1 corresponds to -3600 in the Go zone, not +3600.
        name, offset := Now().In(loc).Zone()
        // The zone abbreviation is "-01" since tzdata-2016g, and "GMT+1"
-       // on earlier versions; we accept both. (Issue #17276).
-       if !(name == "GMT+1" || name == "-01") || offset != -1*60*60 {
-               t.Errorf("Now().In(loc).Zone() = %q, %d, want %q or %q, %d",
-                       name, offset, "GMT+1", "-01", -1*60*60)
+       // on earlier versions; we accept both. (Issue 17276.)
+       wantName := []string{"GMT+1", "-01"}
+       // The zone abbreviation may be "+01" on OpenBSD. (Issue 69840.)
+       if runtime.GOOS == "openbsd" {
+               wantName = append(wantName, "+01")
+       }
+       if !slices.Contains(wantName, name) || offset != -1*60*60 {
+               t.Errorf("Now().In(loc).Zone() = %q, %d, want %q (one of), %d",
+                       name, offset, wantName, -1*60*60)
        }
 }