cmd/go: use filepath.SplitList when inspecting GOPATH

There exists a test case for this condition, but it only runs on unix systems, which neatly dovetails into the code always using ':' as the list separator.

R=adg, iant
CC=golang-dev
https://golang.org/cl/7057052

diff --git a/src/cmd/go/main.go b/src/cmd/go/main.go
index d66be9a2728772c9143dda5161045182ee912e1b..7e34fdfd3aa4a8ad3a4e6917bfcd5939923a7fac 100644 (file)
--- a/src/cmd/go/main.go
+++ b/src/cmd/go/main.go
@@ -128,7 +128,7 @@ func main() {
        if gopath := os.Getenv("GOPATH"); gopath == runtime.GOROOT() {
                fmt.Fprintf(os.Stderr, "warning: GOPATH set to GOROOT (%s) has no effect\n", gopath)
        } else {
-               for _, p := range strings.Split(gopath, ":") {
+               for _, p := range filepath.SplitList(gopath) {
                        if build.IsLocalImport(p) {
                                fmt.Fprintf(os.Stderr, "go: GOPATH entry is relative; must be absolute path: %q.\nRun 'go help gopath' for usage.\n", p)
                                os.Exit(2)