]> Cypherpunks repositories - gostls13.git/commitdiff
net: add testing.Short Skip to test affected by local network configuration
authorDavid Chase <drchase@google.com>
Mon, 9 Jan 2023 18:36:36 +0000 (13:36 -0500)
committerDavid Chase <drchase@google.com>
Sat, 21 Jan 2023 21:06:53 +0000 (21:06 +0000)
If the local network mangles invalid DNS queries, that is not a Go problem.

Change-Id: I54db392532eed988bca81b70a98cd6d11766af89
Reviewed-on: https://go-review.googlesource.com/c/go/+/461275
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/net/dnsclient_unix_test.go

index 3ba19eb813a1518030bfb72fc482a3ebc3f63a54..990b3f99ce4225c90eac155f75a332f2f34484f5 100644 (file)
@@ -2199,6 +2199,9 @@ var goLookupIPCNAMEOrderDNSFilesModeTests = []struct {
 }
 
 func TestGoLookupIPCNAMEOrderHostsAliasesDNSFilesMode(t *testing.T) {
+       if testing.Short() {
+               t.Skip("Makes assumptions about local networks and (re)naming that aren't always true")
+       }
        defer func(orig string) { testHookHostsPath = orig }(testHookHostsPath)
        testHookHostsPath = "testdata/aliases"
        mode := hostLookupDNSFiles