]> Cypherpunks repositories - gostls13.git/commitdiff
encoding/xml: skip TestCVE202230633 for short tests
authorRoland Shoemaker <roland@golang.org>
Thu, 14 Jul 2022 19:09:19 +0000 (12:09 -0700)
committerRoland Shoemaker <roland@golang.org>
Thu, 14 Jul 2022 21:03:14 +0000 (21:03 +0000)
TestCVE202230633 uses a bunch of memory, and the input cannot be
feasibly reduced while maintaining the behavior hasn't regressed. This
test could be reasonably removed, but I'd rather keep it around if we
can.

Fixes #53814

Change-Id: Ie8b3f306efd20b2d9c0fb73122c26351a55694c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/417655
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
src/encoding/xml/read_test.go

index 58d1eddb6123f054eeb6fead8f30e1720df72f53..35385c64909b7397f7ac3d66afe02c01f1371c5f 100644 (file)
@@ -9,7 +9,6 @@ import (
        "errors"
        "io"
        "reflect"
-       "runtime"
        "strings"
        "testing"
        "time"
@@ -1112,8 +1111,8 @@ func TestCVE202228131(t *testing.T) {
 }
 
 func TestCVE202230633(t *testing.T) {
-       if runtime.GOARCH == "wasm" {
-               t.Skip("causes memory exhaustion on js/wasm")
+       if testing.Short() {
+               t.Skip("test requires significant memory")
        }
        defer func() {
                p := recover()