]> Cypherpunks repositories - gostls13.git/commitdiff
runtime/pprof: skip TestTimeVDSO on Android
authorCherry Mui <cherryyz@google.com>
Mon, 27 Sep 2021 18:37:13 +0000 (14:37 -0400)
committerCherry Mui <cherryyz@google.com>
Mon, 27 Sep 2021 21:53:31 +0000 (21:53 +0000)
The test is flaky on Android. VDSO may not be enabled so it may
not have the original problem anyway.

Change-Id: I73c2902c682a44d893e0d4e34f006c2377ef8816
Reviewed-on: https://go-review.googlesource.com/c/go/+/352509
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/runtime/pprof/pprof_test.go

index 8c34d39ad57522c5944bd1ea995225c7ceb36ccc..f39d65c0b5effafddb7f551e20bef0cf1b39b967 100644 (file)
@@ -1650,6 +1650,11 @@ func TestTimeVDSO(t *testing.T) {
        // Test that time functions have the right stack trace. In particular,
        // it shouldn't be recursive.
 
+       if runtime.GOOS == "android" {
+               // Flaky on Android, issue 48655. VDSO may not be enabled.
+               testenv.SkipFlaky(t, 48655)
+       }
+
        p := testCPUProfile(t, stackContains, []string{"time.now"}, avoidFunctions(), func(dur time.Duration) {
                t0 := time.Now()
                for {