]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/ld: fix operator precedence
authorDave Cheney <dave@cheney.net>
Sat, 16 Aug 2014 04:10:35 +0000 (14:10 +1000)
committerDave Cheney <dave@cheney.net>
Sat, 16 Aug 2014 04:10:35 +0000 (14:10 +1000)
Fixes #8480.

This CL reapplies CL 114420043. This attempt doesn't blow up when encountering hidden symbols.

LGTM=minux
R=minux
CC=golang-codereviews
https://golang.org/cl/128310043

src/cmd/ld/data.c

index 1919123b49d079c1cc29b8e512e271e9ff3a3f5e..f76ac0129cd892e00984377aebc956815d4f2304 100644 (file)
@@ -145,7 +145,7 @@ relocsym(LSym *s)
                        diag("%s: invalid relocation %d+%d not in [%d,%d)", s->name, off, siz, 0, s->np);
                        continue;
                }
-               if(r->sym != S && ((r->sym->type & SMASK) == 0 || (r->sym->type & SMASK) == SXREF)) {
+               if(r->sym != S && ((r->sym->type & (SMASK | SHIDDEN)) == 0 || (r->sym->type & SMASK) == SXREF)) {
                        diag("%s: not defined", r->sym->name);
                        continue;
                }