runtime: move linux specific code into linux specific files

Allows us to stop whitelisting this error on many OS/arch combinations

XXX I'm not sure I am running vet correctly, and testing all platforms right.

Change-Id: I29f548bd5f4a63bd13c4d0667d4209c75c886fd9
GitHub-Last-Rev: 52f6ff4a6b986e86f8b26c3d19da7707d39f1664
GitHub-Pull-Request: golang/go#31583
Reviewed-on: https://go-review.googlesource.com/c/go/+/173157
Run-TryBot: Benny Siegert <bsiegert@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>

diff --git a/src/cmd/vet/all/whitelist/darwin_arm.txt b/src/cmd/vet/all/whitelist/darwin_arm.txt
deleted file mode 100644 (file)
index 1c25c6a..0000000
--- a/src/cmd/vet/all/whitelist/darwin_arm.txt
+++ /dev/null
@@ -1,5 +0,0 @@
-// darwin/arm-specific vet whitelist. See readme.txt for details.
-
-// Ok.
-
-runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration

diff --git a/src/cmd/vet/all/whitelist/darwin_arm64.txt b/src/cmd/vet/all/whitelist/darwin_arm64.txt
deleted file mode 100644 (file)
index a1edb71..0000000
--- a/src/cmd/vet/all/whitelist/darwin_arm64.txt
+++ /dev/null
@@ -1,3 +0,0 @@
-// darwin/arm64-specific vet whitelist. See readme.txt for details.
-
-runtime/asm_arm64.s: [arm64] sigreturn: function sigreturn missing Go declaration

diff --git a/src/cmd/vet/all/whitelist/freebsd_arm.txt b/src/cmd/vet/all/whitelist/freebsd_arm.txt
index 11e5c42fd82e82946648d2007d069e160c8f66a6..5cb6989a26c4eb2bf74bc1eff367666375f217db 100644 (file)
--- a/src/cmd/vet/all/whitelist/freebsd_arm.txt
+++ b/src/cmd/vet/all/whitelist/freebsd_arm.txt
@@ -1,4 +1,3 @@
 // freebsd/arm-specific vet whitelist. See readme.txt for details.
 
-runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
 runtime/sys_freebsd_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration

diff --git a/src/cmd/vet/all/whitelist/nacl_arm.txt b/src/cmd/vet/all/whitelist/nacl_arm.txt
index dde0092570234f68025c6476cfe5600f77f542aa..fbdcb5d229cd87e2a42d52bf70b63dfb589ee502 100644 (file)
--- a/src/cmd/vet/all/whitelist/nacl_arm.txt
+++ b/src/cmd/vet/all/whitelist/nacl_arm.txt
@@ -1,6 +1,5 @@
 // nacl/arm-specific vet whitelist. See readme.txt for details.
 
-runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
 runtime/sys_nacl_arm.s: [arm] nacl_clock_gettime: function nacl_clock_gettime missing Go declaration
 runtime/sys_nacl_arm.s: [arm] nacl_sysinfo: function nacl_sysinfo missing Go declaration
 runtime/sys_nacl_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration

diff --git a/src/cmd/vet/all/whitelist/netbsd_arm.txt b/src/cmd/vet/all/whitelist/netbsd_arm.txt
index c0a0aa2114e51703a82e3bcf461b79b73aa5d420..85adae21293be7c54b2be39d4f0cb2d256133c5b 100644 (file)
--- a/src/cmd/vet/all/whitelist/netbsd_arm.txt
+++ b/src/cmd/vet/all/whitelist/netbsd_arm.txt
@@ -1,5 +1,4 @@
 // netbsd/arm-specific vet whitelist. See readme.txt for details.
 
-runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
 runtime/sys_netbsd_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration
 syscall/asm_netbsd_arm.s: [arm] Syscall9: unknown variable trap; offset 0 is num+0(FP)

diff --git a/src/cmd/vet/all/whitelist/openbsd_arm.txt b/src/cmd/vet/all/whitelist/openbsd_arm.txt
index 16bf26c73490c4bc8f80023bf0612060af546ef1..14823e1bf886e0fcfc1f423d74212b04aff4f288 100644 (file)
--- a/src/cmd/vet/all/whitelist/openbsd_arm.txt
+++ b/src/cmd/vet/all/whitelist/openbsd_arm.txt
@@ -1,4 +1,3 @@
 // openbsd/arm-specific vet whitelist. See readme.txt for details.
 
-runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
 runtime/sys_openbsd_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration

diff --git a/src/cmd/vet/all/whitelist/plan9_arm.txt b/src/cmd/vet/all/whitelist/plan9_arm.txt
index 5af32717606b5b9d2d06d7a141d28f83321ddbef..af155e819fe102536362a9c50ab3fce9d18df7b8 100644 (file)
--- a/src/cmd/vet/all/whitelist/plan9_arm.txt
+++ b/src/cmd/vet/all/whitelist/plan9_arm.txt
@@ -1,4 +1,3 @@
 // plan9/arm-specific vet whitelist. See readme.txt for details.
 
-runtime/asm_arm.s: [arm] sigreturn: function sigreturn missing Go declaration
 runtime/sys_plan9_arm.s: [arm] read_tls_fallback: function read_tls_fallback missing Go declaration

diff --git a/src/runtime/asm_arm.s b/src/runtime/asm_arm.s
index 5c6dfedac8846de5680953d2017626c669bceef0..efd0e2a1a257e1c2d35f1acb805763ffd4942230 100644 (file)
--- a/src/runtime/asm_arm.s
+++ b/src/runtime/asm_arm.s
@@ -891,9 +891,6 @@ TEXT runtime·usplitR0(SB),NOSPLIT,$0
        SUB     R1, R3, R1
        RET
 
-TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
-       RET
-
 #ifndef GOOS_nacl
 // This is called from .init_array and follows the platform, not Go, ABI.
 TEXT runtime·addmoduledata(SB),NOSPLIT,$0-8

diff --git a/src/runtime/asm_arm64.s b/src/runtime/asm_arm64.s
index 871dc95deaec462acb60bc91d49f3d1c6561525e..6e3b1b14a6ae5fa9de57c8802ee099f3cb527776 100644 (file)
--- a/src/runtime/asm_arm64.s
+++ b/src/runtime/asm_arm64.s
@@ -1128,9 +1128,6 @@ TEXT runtime·goexit(SB),NOSPLIT|NOFRAME|TOPFRAME,$0-0
        MOVD    R0, R0  // NOP
        BL      runtime·goexit1(SB)    // does not return
 
-TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
-       RET
-
 // This is called from .init_array and follows the platform, not Go, ABI.
 TEXT runtime·addmoduledata(SB),NOSPLIT,$0-0
        SUB     $0x10, RSP

diff --git a/src/runtime/sys_linux_arm.s b/src/runtime/sys_linux_arm.s
index 43a58335c8068a105fc31005a3f5ea5cefbb8995..637123be45f8b4d34e67250b53b8f16597d2e6dc 100644 (file)
--- a/src/runtime/sys_linux_arm.s
+++ b/src/runtime/sys_linux_arm.s
@@ -606,3 +606,6 @@ TEXT runtime·sbrk0(SB),NOSPLIT,$0-4
        SWI     $0
        MOVW    R0, ret+0(FP)
        RET
+
+TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
+       RET

diff --git a/src/runtime/sys_linux_arm64.s b/src/runtime/sys_linux_arm64.s
index 8b344be8f83b9e4c5c2888c1b62922e554f1480e..321d74254c6e58f206412d972553223f0688add8 100644 (file)
--- a/src/runtime/sys_linux_arm64.s
+++ b/src/runtime/sys_linux_arm64.s
@@ -599,3 +599,6 @@ TEXT runtime·sbrk0(SB),NOSPLIT,$0-8
        SVC
        MOVD    R0, ret+0(FP)
        RET
+
+TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
+       RET