]> Cypherpunks repositories - gostls13.git/commitdiff
misc/cgo/testplugin: remove skip in TestIssue25756pie
authorDmitri Shuralyov <dmitshur@golang.org>
Mon, 6 Dec 2021 23:05:53 +0000 (18:05 -0500)
committerDmitri Shuralyov <dmitshur@golang.org>
Tue, 7 Dec 2021 00:03:34 +0000 (00:03 +0000)
Though this was a problem for Go 1.17,
it appears not to be a problem on tip.

This reverts change made in CL 321349.

For #46239.

Change-Id: Ie4d6649fbabce3bb2c1cf04d97760ba6ceadaca5
Reviewed-on: https://go-review.googlesource.com/c/go/+/369752
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>

misc/cgo/testplugin/plugin_test.go

index 9697dbf7a78e3c35b2a60ed168f8a254e67e94b0..a6accc1dfbba9e76cd674735618b9a4f8f9793b9 100644 (file)
@@ -265,10 +265,6 @@ func TestIssue25756(t *testing.T) {
 
 // Test with main using -buildmode=pie with plugin for issue #43228
 func TestIssue25756pie(t *testing.T) {
-       if os.Getenv("GO_BUILDER_NAME") == "darwin-arm64-11_0-toothrot" {
-               t.Skip("broken on darwin/arm64 builder in sharded mode; see issue 46239")
-       }
-
        goCmd(t, "build", "-buildmode=plugin", "-o", "life.so", "./issue25756/plugin")
        goCmd(t, "build", "-buildmode=pie", "-o", "issue25756pie.exe", "./issue25756/main.go")
        run(t, "./issue25756pie.exe")