]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: remove windows-amd64-2008 code path
authorqmuntal <quimmuntal@gmail.com>
Fri, 10 Feb 2023 09:36:16 +0000 (10:36 +0100)
committerQuim Muntal <quimmuntal@gmail.com>
Fri, 10 Feb 2023 15:04:24 +0000 (15:04 +0000)
`windows-amd64-2008` builder does no longer exist on go1.20,
so it is safe to remove conditions checking for that name.

Updates #57003
Closes #56904

Change-Id: I941ccc64cda0af3b9356996c4b581700afa81987
Reviewed-on: https://go-review.googlesource.com/c/go/+/467175
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/dist/test.go

index 35a9b50a7006f0217df7ccd57a8da05eac37d57d..4395d3a33bd05dad42e9c0bb4571666db9c0b581 100644 (file)
@@ -1568,13 +1568,6 @@ func (t *tester) registerRaceTests() {
                // t.registerTest("race:misc/cgo/test", hdr, &goTest{dir: "../misc/cgo/test", race: true, env: []string{"GOTRACEBACK=2"}})
        }
        if t.extLink() {
-               var oldWindows rtPreFunc
-               if strings.HasPrefix(os.Getenv("GO_BUILDER_NAME"), "windows-amd64-2008") {
-                       oldWindows.pre = func(*distTest) bool {
-                               fmt.Println("skipping -race with external linkage on older windows builder, see https://github.com/golang/go/issues/56904 for details")
-                               return false
-                       }
-               }
                // Test with external linking; see issue 9133.
                t.registerTest("race:external", hdr,
                        &goTest{
@@ -1582,7 +1575,7 @@ func (t *tester) registerRaceTests() {
                                ldflags:  "-linkmode=external",
                                runTests: "TestParse|TestEcho|TestStdinCloseRace",
                                pkgs:     []string{"flag", "os/exec"},
-                       }, oldWindows)
+                       })
        }
 }