]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: address comments from previous review
authorBenny Siegert <bsiegert@gmail.com>
Thu, 12 Apr 2018 14:32:40 +0000 (16:32 +0200)
committerTobias Klauser <tobias.klauser@gmail.com>
Thu, 12 Apr 2018 15:07:37 +0000 (15:07 +0000)
Move the test skip to use testenv.SkipFlaky and link to the Go issue.

Update #24826

Change-Id: I7a0ea3325ffcaa790b25f8cdc429fb52e96a41c7
Reviewed-on: https://go-review.googlesource.com/106636
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/http/serve_test.go

index 05e31ef1e4fc2f234cd808ff9550b9102678ec10..49239b367126a13165c95f86b40b8bce262a0b97 100644 (file)
@@ -5630,8 +5630,7 @@ func runTimeSensitiveTest(t *testing.T, durations []time.Duration, test func(t *
 // read if it's already done one.
 func TestServerDuplicateBackgroundRead(t *testing.T) {
        if runtime.GOOS == "netbsd" && runtime.GOARCH == "arm" {
-               // http://gnats.netbsd.org/53173
-               t.Skip("skipping to avoid crash")
+               testenv.SkipFlaky(t, 24826)
        }
 
        setParallel(t)