all: use strings.Builder instead of bytes.Buffer

Change-Id: I6d7213d29ade591b8366d5640833bd5a20474165
GitHub-Last-Rev: 94195832873fe6764d45ffdd6efa1ca49e57a743
GitHub-Pull-Request: golang/go#54834
Reviewed-on: https://go-review.googlesource.com/c/go/+/427814
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: hopehook <hopehook@golangcn.org>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>

diff --git a/src/cmd/go/internal/str/str.go b/src/cmd/go/internal/str/str.go
index 975869d760165f6014f2d9093241a6b04fb290ab..af7c6999722fa589dde9eca6ea39f758407b6971 100644 (file)
--- a/src/cmd/go/internal/str/str.go
+++ b/src/cmd/go/internal/str/str.go
@@ -6,8 +6,8 @@
 package str
 
 import (
-       "bytes"
        "fmt"
+       "strings"
        "unicode"
        "unicode/utf8"
 )
@@ -49,7 +49,7 @@ func ToFold(s string) string {
        return s
 
 Slow:
-       var buf bytes.Buffer
+       var b strings.Builder
        for _, r := range s {
                // SimpleFold(x) cycles to the next equivalent rune > x
                // or wraps around to smaller values. Iterate until it wraps,
@@ -65,9 +65,9 @@ Slow:
                if 'A' <= r && r <= 'Z' {
                        r += 'a' - 'A'
                }
-               buf.WriteRune(r)
+               b.WriteRune(r)
        }
-       return buf.String()
+       return b.String()
 }
 
 // FoldDup reports a pair of strings from the list that are

diff --git a/src/go/internal/gccgoimporter/parser.go b/src/go/internal/gccgoimporter/parser.go
index 536083ae08cdb186647b46ab543ded3d8c20bb36..de9df0bbfb07d075801151e4d3a7471a53cdb711 100644 (file)
--- a/src/go/internal/gccgoimporter/parser.go
+++ b/src/go/internal/gccgoimporter/parser.go
@@ -5,7 +5,6 @@
 package gccgoimporter
 
 import (
-       "bytes"
        "errors"
        "fmt"
        "go/constant"
@@ -129,16 +128,16 @@ func (p *parser) parseUnquotedString() string {
        if p.tok == scanner.EOF {
                p.error("unexpected EOF")
        }
-       var buf bytes.Buffer
-       buf.WriteString(p.scanner.TokenText())
+       var b strings.Builder
+       b.WriteString(p.scanner.TokenText())
        // This loop needs to examine each character before deciding whether to consume it. If we see a semicolon,
        // we need to let it be consumed by p.next().
        for ch := p.scanner.Peek(); ch != '\n' && ch != ';' && ch != scanner.EOF && p.scanner.Whitespace&(1<<uint(ch)) == 0; ch = p.scanner.Peek() {
-               buf.WriteRune(ch)
+               b.WriteRune(ch)
                p.scanner.Next()
        }
        p.next()
-       return buf.String()
+       return b.String()
 }
 
 func (p *parser) next() {

diff --git a/src/net/mail/message.go b/src/net/mail/message.go
index c91aa3af124676acc5b513f9654d2c6e6792be68..5de47eb45b69900cd746a7febab5830d2814196d 100644 (file)
--- a/src/net/mail/message.go
+++ b/src/net/mail/message.go
@@ -829,18 +829,18 @@ func isQtext(r rune) bool {
 
 // quoteString renders a string as an RFC 5322 quoted-string.
 func quoteString(s string) string {
-       var buf strings.Builder
-       buf.WriteByte('"')
+       var b strings.Builder
+       b.WriteByte('"')
        for _, r := range s {
                if isQtext(r) || isWSP(r) {
-                       buf.WriteRune(r)
+                       b.WriteRune(r)
                } else if isVchar(r) {
-                       buf.WriteByte('\\')
-                       buf.WriteRune(r)
+                       b.WriteByte('\\')
+                       b.WriteRune(r)
                }
        }
-       buf.WriteByte('"')
-       return buf.String()
+       b.WriteByte('"')
+       return b.String()
 }
 
 // isVchar reports whether r is an RFC 5322 VCHAR character.