]> Cypherpunks repositories - gostls13.git/commitdiff
crypto/x509: switch test to ParseRevocationList
authorAlexander Scheel <alex.scheel@hashicorp.com>
Thu, 3 Nov 2022 13:09:31 +0000 (13:09 +0000)
committerGopher Robot <gobot@golang.org>
Thu, 3 Nov 2022 17:40:21 +0000 (17:40 +0000)
In following with Roland's TODO, switch TestDisableSHA1ForCertOnly to ParseRevocationList(...) over ParseCRL(...).

Change-Id: I8cdaf04ad0a1c8b94303415ae41933657067041e
GitHub-Last-Rev: bb2ef760e4fdd8c0c9228004674d4e1f581c4271
GitHub-Pull-Request: golang/go#56541
Reviewed-on: https://go-review.googlesource.com/c/go/+/447036
Reviewed-by: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>

src/crypto/x509/x509_test.go

index 44441d45d49d8ac51a8dcd6da84d77ba90b31e8d..0ba6d3e9fa487a8092d3c181da4ae1174b170af3 100644 (file)
@@ -3553,13 +3553,12 @@ func TestDisableSHA1ForCertOnly(t *testing.T) {
        if err != nil {
                t.Fatalf("failed to generate test CRL: %s", err)
        }
-       // TODO(rolandshoemaker): this should be ParseRevocationList once it lands
-       crl, err := ParseCRL(crlDER)
+       crl, err := ParseRevocationList(crlDER)
        if err != nil {
                t.Fatalf("failed to parse test CRL: %s", err)
        }
 
-       if err = cert.CheckCRLSignature(crl); err != nil {
+       if err = crl.CheckSignatureFrom(cert); err != nil {
                t.Errorf("unexpected error: %s", err)
        }