]> Cypherpunks repositories - gostls13.git/commitdiff
debug/dwarf: clarify StructField.ByteSize doc
authorHeschi Kreinick <heschi@google.com>
Wed, 18 Oct 2017 18:29:21 +0000 (14:29 -0400)
committerHeschi Kreinick <heschi@google.com>
Wed, 18 Oct 2017 21:45:30 +0000 (21:45 +0000)
StructField.ByteSize is almost always unset; document that Type.Size()
is the place to look.

The dwarf package doesn't spend much effort teaching you DWARF, so I
don't know what level of handholding is appropriate. Still, no harm in a
little comment.

Closes #21093

Change-Id: I0ed8cad2fa18e10a47d264ff16c176d603d6033c
Reviewed-on: https://go-review.googlesource.com/71671
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/debug/dwarf/type.go

index 72ef816cc202bb7eef89ba8b8f9e17d9cdcb9217..4352092ed0d7bd893941a24c5aa31d2e96d7aec2 100644 (file)
@@ -154,7 +154,7 @@ type StructField struct {
        Name       string
        Type       Type
        ByteOffset int64
-       ByteSize   int64
+       ByteSize   int64 // usually zero; use Type.Size() for normal fields
        BitOffset  int64 // within the ByteSize bytes at ByteOffset
        BitSize    int64 // zero if not a bit field
 }