]> Cypherpunks repositories - gostls13.git/commitdiff
go/internal/gcimporter: add unit tests for blank parameter names
authorMatthew Dempsky <mdempsky@google.com>
Tue, 17 Apr 2018 21:53:56 +0000 (14:53 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Tue, 17 Apr 2018 23:46:11 +0000 (23:46 +0000)
cmd/compile internally rewrites blank return parameters to "~bN". Add
a test to make sure this isn't exposed via the go/types API.

Change-Id: I319644dc5adf483ed30520fd8e9d88cf5cea9751
Reviewed-on: https://go-review.googlesource.com/107616
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/go/internal/gcimporter/gcimporter_test.go

index 63abf97e7e834e1f5211b2851f841cb10d1acaaa..4d5757fce9494bac45e31d2f6a5241536199be3b 100644 (file)
@@ -207,6 +207,8 @@ var importedObjectTests = []struct {
        {"go/types.Comparable", "func Comparable(T Type) bool"},
        {"math.Pi", "const Pi untyped float"},
        {"math.Sin", "func Sin(x float64) float64"},
+       {"go/ast.NotNilFilter", "func NotNilFilter(_ string, v reflect.Value) bool"},
+       {"go/internal/gcimporter.BImportData", "func BImportData(fset *go/token.FileSet, imports map[string]*go/types.Package, data []byte, path string) (_ int, pkg *go/types.Package, err error)"},
 
        // interfaces
        {"context.Context", "type Context interface{Deadline() (deadline time.Time, ok bool); Done() <-chan struct{}; Err() error; Value(key interface{}) interface{}}"},