]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: use DOMException.message property in error text
authorDmitri Shuralyov <dmitshur@golang.org>
Sun, 29 Mar 2020 03:25:18 +0000 (23:25 -0400)
committerDmitri Shuralyov <dmitshur@golang.org>
Sun, 29 Mar 2020 18:37:17 +0000 (18:37 +0000)
Previously, details about the underlying fetch error
were not visible in the net/http error text:

net/http: fetch() failed: <object>

When using the message property, they are:

net/http: fetch() failed: Failed to fetch
net/http: fetch() failed: The user aborted a request.

Reference: https://developer.mozilla.org/en-US/docs/Web/API/DOMException/message.

Change-Id: Iecf7c6bac01abb164731a4d5c9af6582c250a1a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/226205
Reviewed-by: Johan Brandhorst <johan.brandhorst@gmail.com>
src/net/http/roundtrip_js.go

index 4dd99651a7bae5b813f2ec2454641f8829a6de98..e14f3f71521f3a213be068a15eef735ed3b3d8a9 100644 (file)
@@ -157,7 +157,7 @@ func (t *Transport) RoundTrip(req *Request) (*Response, error) {
        })
        defer success.Release()
        failure := js.FuncOf(func(this js.Value, args []js.Value) interface{} {
-               err := fmt.Errorf("net/http: fetch() failed: %s", args[0].String())
+               err := fmt.Errorf("net/http: fetch() failed: %s", args[0].Get("message").String())
                select {
                case errCh <- err:
                case <-req.Context().Done():