]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: don't run TestUserOverrideFlags in parallel
authorIan Lance Taylor <iant@golang.org>
Tue, 7 Nov 2017 23:03:53 +0000 (15:03 -0800)
committerIan Lance Taylor <iant@golang.org>
Tue, 7 Nov 2017 23:27:28 +0000 (23:27 +0000)
It creates files in the cmd/go directory, which can confuse other tests.

Fixes #22584.

Change-Id: Iad5a25c62e7d413af1648dbc5359ed78bfd61d2a
Reviewed-on: https://go-review.googlesource.com/76398
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/go/go_test.go

index ca1e392833a0e8d4bb1794a42ca62be3f33293ed..c2a4f517ecb0108cbede84645bd0fcabba5a6827 100644 (file)
@@ -4342,7 +4342,8 @@ func TestUserOverrideFlags(t *testing.T) {
 
        tg := testgo(t)
        defer tg.cleanup()
-       tg.parallel()
+       // Don't call tg.parallel, as creating override.h and override.a may
+       // confuse other tests.
        tg.tempFile("override.go", `package main
 
 import "C"