]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: say where the compiler knows about var writeBarrier
authorAustin Clements <austin@google.com>
Fri, 7 Apr 2017 22:06:12 +0000 (18:06 -0400)
committerAustin Clements <austin@google.com>
Sun, 9 Apr 2017 23:05:24 +0000 (23:05 +0000)
The runtime.writeBarrier variable tries to be helpful by telling you
that the compiler also knows about this variable, which you could
probably guess, but doesn't say how the compiler knows about it. In
fact, the compiler has a complete copy in builtin/runtime.go that
needs to be kept in sync. Say so.

Change-Id: Ia7fb0c591cb6f9b8230decce01008b417dfcec89
Reviewed-on: https://go-review.googlesource.com/40150
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/mgc.go

index 03a58c3b27755c4642485da21df0b1b63ce67755..b79617edf7a27479f0c33ff309b3c9d7a5bec3a1 100644 (file)
@@ -238,7 +238,9 @@ func setGCPercent(in int32) (out int32) {
 var gcphase uint32
 
 // The compiler knows about this variable.
-// If you change it, you must change the compiler too.
+// If you change it, you must change builtin/runtime.go, too.
+// If you change the first four bytes, you must also change the write
+// barrier insertion code.
 var writeBarrier struct {
        enabled bool    // compiler emits a check of this before calling write barrier
        pad     [3]byte // compiler uses 32-bit load for "enabled" field