net/http: remove five second timeout from TestTransportClosesBodyOnError

Wait forever and let the test time out with a stack trace if the
expected response doesn't happen.

Fixes #57990

Change-Id: I835def63db113752cdd06e03e258cb10d63a6a25
Reviewed-on: https://go-review.googlesource.com/c/go/+/463222
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>

diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go
index 2879dee0fd26d931f8cb2010b1a6923ef6b70840..cb5af755dbb42b240dfbecd7b71ecaf666dc8b49 100644 (file)
--- a/src/net/http/transport_test.go
+++ b/src/net/http/transport_test.go
@@ -3700,13 +3700,8 @@ func testTransportClosesBodyOnError(t *testing.T, mode testMode) {
        if err == nil || !strings.Contains(err.Error(), fakeErr.Error()) {
                t.Fatalf("Do error = %v; want something containing %q", err, fakeErr.Error())
        }
-       select {
-       case err := <-readBody:
-               if err == nil {
-                       t.Errorf("Unexpected success reading request body from handler; want 'unexpected EOF reading trailer'")
-               }
-       case <-time.After(5 * time.Second):
-               t.Error("timeout waiting for server handler to complete")
+       if err := <-readBody; err == nil {
+               t.Errorf("Unexpected success reading request body from handler; want 'unexpected EOF reading trailer'")
        }
        select {
        case <-didClose: