]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: enable upx compression test on linux/386
authorAlberto Donizetti <alb.donizetti@gmail.com>
Wed, 2 May 2018 10:58:18 +0000 (12:58 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 2 May 2018 14:41:32 +0000 (14:41 +0000)
We have a cmd/go test ensuring that upx (an executable
packer/compressor) works on linux/amd64 Go binaries.

The linux-386-sid builder is built from the same dockerfile as the
linux-amd64-sid builder, so upx should also already be available on
the former. Since upx support 386 executables, we can enable the upx
test for GOARCH=386.

Updates #16706

Change-Id: I94e19ff1001de83a0386754a5104a377c72fb221
Reviewed-on: https://go-review.googlesource.com/110817
Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/go/go_test.go

index 19e4116eb39ab38057f52b8c40ae9d2db1fdf3fd..2b2e17a71a29bf7b179ba812cca7ea449bdd2643 100644 (file)
@@ -5037,7 +5037,8 @@ func TestWrongGOOSErrorBeforeLoadError(t *testing.T) {
 }
 
 func TestUpxCompression(t *testing.T) {
-       if runtime.GOOS != "linux" || runtime.GOARCH != "amd64" {
+       if runtime.GOOS != "linux" ||
+               (runtime.GOARCH != "amd64" && runtime.GOARCH != "386") {
                t.Skipf("skipping upx test on %s/%s", runtime.GOOS, runtime.GOARCH)
        }