]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "cmd/compile: improve generated eq algs for structs containing interfaces"
authorKeith Randall <khr@golang.org>
Wed, 3 Jun 2020 17:02:10 +0000 (17:02 +0000)
committerKeith Randall <khr@golang.org>
Wed, 3 Jun 2020 17:38:12 +0000 (17:38 +0000)
This reverts commit 1cc7be89a94951cbd1b6db669cb5a278e7aea545.

Reason for revert: Undoing to get back to semantics discussed in #8606.

Change-Id: Ib44a2e79cf113b3d15c3546cd8aa6fc27860819e
Reviewed-on: https://go-review.googlesource.com/c/go/+/236146
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/alg.go

index 835e7e73ba33efcf7559d4db0593d42d460337f6..b55109bbbc07a9a02a07115f13e48d33e31ddd99 100644 (file)
@@ -672,14 +672,6 @@ func geneq(t *types.Type) *obj.LSym {
                                        eqlen, eqmem := eqstring(p, q)
                                        and(eqlen)
                                        and(eqmem)
-                               case f.Type.IsInterface():
-                                       p.Type = f.Type
-                                       p = typecheck(p, ctxExpr)
-                                       q.Type = f.Type
-                                       q = typecheck(q, ctxExpr)
-                                       eqtab, eqdata := eqinterface(p, q)
-                                       and(eqtab)
-                                       and(eqdata)
                                default:
                                        and(nod(OEQ, p, q))
                                }