]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: remove unnecessary sync from publicationBarrier on s390x
authorBill O'Farrell <billo@ca.ibm.com>
Fri, 27 Oct 2017 18:40:59 +0000 (14:40 -0400)
committerMichael Munday <mike.munday@ibm.com>
Mon, 30 Oct 2017 23:42:27 +0000 (23:42 +0000)
Memory accesses on z are at least as ordered as they are on AMD64.

Change-Id: Ia515430e571ebd07e9314de05c54dc992ab76b95
Reviewed-on: https://go-review.googlesource.com/74010
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Munday <mike.munday@ibm.com>
src/runtime/asm_s390x.s

index 42b93266074b82cbc0c6bc98ecd6d81ce9801a22..487ed62306cce6e09b3046bc82bbd7eba6ab07ed 100644 (file)
@@ -915,7 +915,8 @@ TEXT runtime·sigreturn(SB),NOSPLIT,$0-0
        RET
 
 TEXT ·publicationBarrier(SB),NOSPLIT|NOFRAME,$0-0
-       SYNC
+        // Stores are already ordered on s390x, so this is just a
+        // compile barrier.
        RET
 
 TEXT runtime·cmpstring(SB),NOSPLIT|NOFRAME,$0-40