cmd/compile: don't expand invalid embedded interface

The invalid interface type will be reported already, so don't expand
that invalid one, which causes the compiler crashes.

Updates #43311

Change-Id: Ic335cfa74f0b9fcfd0929dc5fd31d9156a8f5f5c
Reviewed-on: https://go-review.googlesource.com/c/go/+/298710
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>

diff --git a/src/cmd/compile/internal/types/size.go b/src/cmd/compile/internal/types/size.go
index 4c7378560cc532a1fb7998b787632fa48b20f8c0..ef23cdf5fe3bbbec78a48733b13eea7ac65666c8 100644 (file)
--- a/src/cmd/compile/internal/types/size.go
+++ b/src/cmd/compile/internal/types/size.go
@@ -100,7 +100,7 @@ func expandiface(t *Type) {
        }
 
        for _, m := range t.Methods().Slice() {
-               if m.Sym != nil {
+               if m.Sym != nil || m.Type == nil {
                        continue
                }
 

diff --git a/test/fixedbugs/issue20245.go b/test/fixedbugs/issue20245.go
index b07dbe20de677cd3c14c8a60eaf87afaccf918f7..20258231d1207a12ded45c58dcab414ca7b929ca 100644 (file)
--- a/test/fixedbugs/issue20245.go
+++ b/test/fixedbugs/issue20245.go
@@ -1,4 +1,4 @@
-// errorcheck
+// errorcheck -d=panic
 
 // Copyright 2017 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style

diff --git a/test/fixedbugs/issue22921.go b/test/fixedbugs/issue22921.go
index 5336ba34109f9945db72870fe14642eb2ce57d7f..cdd77fb24f2fdedd58bbfa2bb0cd6eb49602b6c8 100644 (file)
--- a/test/fixedbugs/issue22921.go
+++ b/test/fixedbugs/issue22921.go
@@ -1,4 +1,4 @@
-// errorcheck
+// errorcheck -d=panic
 
 // Copyright 2020 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style

diff --git a/test/fixedbugs/issue27938.go b/test/fixedbugs/issue27938.go
index ed974e642df576a34a1fdfca8e7b55672eecf819..2589e1eff8d2f5239e7c4dd0c3fef46b4027c352 100644 (file)
--- a/test/fixedbugs/issue27938.go
+++ b/test/fixedbugs/issue27938.go
@@ -1,4 +1,4 @@
-// errorcheck
+// errorcheck -d=panic
 
 // Copyright 2018 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style