]> Cypherpunks repositories - gostls13.git/commitdiff
os/user: allow LookupGroupId to fail during test
authorRuss Cox <rsc@golang.org>
Mon, 14 Mar 2016 01:34:46 +0000 (21:34 -0400)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 15 Mar 2016 16:25:40 +0000 (16:25 +0000)
On my Mac I am in group 5000 which apparently has no name
(I suspect because it is an LDAP group and I cannot reach the
LDAP server). Do not make the test fail in that case.

Fixes #14806

Change-Id: I56b11a8e86b048abfb00812eaad37802fd2adcc5
Reviewed-on: https://go-review.googlesource.com/20710
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/os/user/user_test.go

index 361c48a7bddb07c8b6ffd35754dbb4949535a7dd..9d8d94d8dae2243f8deeeebf660317f075cf1980 100644 (file)
@@ -104,7 +104,11 @@ func TestLookupGroup(t *testing.T) {
 
        g1, err := LookupGroupId(user.Gid)
        if err != nil {
-               t.Fatalf("LookupGroupId(%q): %v", user.Gid, err)
+               // NOTE(rsc): Maybe the group isn't defined. That's fine.
+               // On my OS X laptop, rsc logs in with group 5000 even
+               // though there's no name for group 5000. Such is Unix.
+               t.Logf("LookupGroupId(%q): %v", user.Gid, err)
+               return
        }
        if g1.Gid != user.Gid {
                t.Errorf("LookupGroupId(%q).Gid = %s; want %s", user.Gid, g1.Gid, user.Gid)