]> Cypherpunks repositories - gostls13.git/commitdiff
runtime/race: update darwin race syso
authorCherry Mui <cherryyz@google.com>
Tue, 25 Mar 2025 19:21:04 +0000 (15:21 -0400)
committerCherry Mui <cherryyz@google.com>
Wed, 6 Aug 2025 21:34:39 +0000 (14:34 -0700)
On macOS, the script in LLVM TSAN building the race syso files
produces the Mach-O object with a malformed dynamic symbol table,
which new Apple linker doesn't like and emits an annoying warning
(https://github.com/golang/go/issues/61229#issuecomment-1988965927).
The dynamic symbol table isn't really needed, as it is a static
object. Perhaps it should be fixed in TSAN or the C toolchain, but
we can do a simple workaround: pass it through "ld -r", which
produces an equivalent object file with LC_DYSYMTAB removed.
CL 692975 changes racebuild to do this, which produces new syso's
in this CL.

While here, build the syso with a newer version of LLVM TSAN.

Updates #61229.

Change-Id: Ide4b7831eb2cb6877c8ace7b3ec8ff565a9eaf54
Reviewed-on: https://go-review.googlesource.com/c/go/+/692996
Reviewed-by: David Chase <drchase@google.com>
TryBot-Bypass: Cherry Mui <cherryyz@google.com>

src/runtime/race/README
src/runtime/race/internal/amd64v1/race_darwin.syso
src/runtime/race/race_darwin_amd64.go
src/runtime/race/race_darwin_arm64.go
src/runtime/race/race_darwin_arm64.syso

index def7bfec868308c2e4fdf73d7c838cfcff7f6cef..4fc20efeb309659bea945278e2b22dd2dc65fef3 100644 (file)
@@ -4,14 +4,14 @@ the LLVM project (https://github.com/llvm/llvm-project/tree/main/compiler-rt).
 
 To update the .syso files use golang.org/x/build/cmd/racebuild.
 
-internal/amd64v1/race_darwin.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
+internal/amd64v1/race_darwin.syso built with LLVM 0398ad41bdf1ce5f74c80a74494bfe733fe3e214 and Go b2960e35804aafbbb0df9973f99b034bea8c150a.
 internal/amd64v1/race_freebsd.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
 internal/amd64v1/race_linux.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
 internal/amd64v1/race_netbsd.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
 internal/amd64v1/race_openbsd.syso built with LLVM fcf6ae2f070eba73074b6ec8d8281e54d29dbeeb and Go 8f2db14cd35bbd674cb2988a508306de6655e425.
 internal/amd64v1/race_windows.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
 internal/amd64v3/race_linux.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
-race_darwin_arm64.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
+race_darwin_arm64.syso built with LLVM 0398ad41bdf1ce5f74c80a74494bfe733fe3e214 and Go b2960e35804aafbbb0df9973f99b034bea8c150a.
 race_linux_arm64.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
 race_linux_loong64.syso built with LLVM 83fe85115da9dc25fa270d2ea8140113c8d49670 and Go 037112464b4439571b45536de9ebe4bc9e10ecb7.
 race_linux_ppc64le.syso built with LLVM 51bfeff0e4b0757ff773da6882f4d538996c9b04 and Go e7d582b55dda36e76ce4d0ce770139ca0915b7c5.
index e92f4ce74533f71060b4f4caafc1201e5c2c5daa..eb9782e105a15110b89817299ac9dabc0f06dcbc 100644 (file)
Binary files a/src/runtime/race/internal/amd64v1/race_darwin.syso and b/src/runtime/race/internal/amd64v1/race_darwin.syso differ
index 02d73f8d388d3cc8f0f03d8beea5761ccbe3eee8..ef92e41c2760ccc841f459cd03da707167d62447 100644 (file)
@@ -28,9 +28,6 @@ package race
 //go:cgo_import_dynamic _dyld_get_shared_cache_uuid _dyld_get_shared_cache_uuid ""
 //go:cgo_import_dynamic _dyld_image_count _dyld_image_count ""
 //go:cgo_import_dynamic _exit _exit ""
-//go:cgo_import_dynamic _sanitizer_internal_memcpy _sanitizer_internal_memcpy ""
-//go:cgo_import_dynamic _sanitizer_internal_memmove _sanitizer_internal_memmove ""
-//go:cgo_import_dynamic _sanitizer_internal_memset _sanitizer_internal_memset ""
 //go:cgo_import_dynamic abort abort ""
 //go:cgo_import_dynamic arc4random_buf arc4random_buf ""
 //go:cgo_import_dynamic close close ""
@@ -40,6 +37,7 @@ package race
 //go:cgo_import_dynamic dyld_shared_cache_iterate_text dyld_shared_cache_iterate_text ""
 //go:cgo_import_dynamic execve execve ""
 //go:cgo_import_dynamic exit exit ""
+//go:cgo_import_dynamic fcntl fcntl ""
 //go:cgo_import_dynamic fstat$INODE64 fstat$INODE64 ""
 //go:cgo_import_dynamic ftruncate ftruncate ""
 //go:cgo_import_dynamic getpid getpid ""
@@ -57,7 +55,6 @@ package race
 //go:cgo_import_dynamic madvise madvise ""
 //go:cgo_import_dynamic malloc_num_zones malloc_num_zones ""
 //go:cgo_import_dynamic malloc_zones malloc_zones ""
-//go:cgo_import_dynamic memcpy memcpy ""
 //go:cgo_import_dynamic memset_pattern16 memset_pattern16 ""
 //go:cgo_import_dynamic mkdir mkdir ""
 //go:cgo_import_dynamic mprotect mprotect ""
@@ -103,6 +100,3 @@ package race
 //go:cgo_import_dynamic vm_region_recurse_64 vm_region_recurse_64 ""
 //go:cgo_import_dynamic waitpid waitpid ""
 //go:cgo_import_dynamic write write ""
-//go:cgo_import_dynamic memcpy memcpy ""
-//go:cgo_import_dynamic memmove memmove ""
-//go:cgo_import_dynamic memset memset ""
index cb703a6dedd3de2038897d785167f5ce5e1dba6a..97eab4d6840acd02172e931e0497e8870ab4cc11 100644 (file)
@@ -27,9 +27,6 @@ package race
 //go:cgo_import_dynamic _dyld_get_shared_cache_uuid _dyld_get_shared_cache_uuid ""
 //go:cgo_import_dynamic _dyld_image_count _dyld_image_count ""
 //go:cgo_import_dynamic _exit _exit ""
-//go:cgo_import_dynamic _sanitizer_internal_memcpy _sanitizer_internal_memcpy ""
-//go:cgo_import_dynamic _sanitizer_internal_memmove _sanitizer_internal_memmove ""
-//go:cgo_import_dynamic _sanitizer_internal_memset _sanitizer_internal_memset ""
 //go:cgo_import_dynamic abort abort ""
 //go:cgo_import_dynamic arc4random_buf arc4random_buf ""
 //go:cgo_import_dynamic bzero bzero ""
@@ -40,6 +37,7 @@ package race
 //go:cgo_import_dynamic dyld_shared_cache_iterate_text dyld_shared_cache_iterate_text ""
 //go:cgo_import_dynamic execve execve ""
 //go:cgo_import_dynamic exit exit ""
+//go:cgo_import_dynamic fcntl fcntl ""
 //go:cgo_import_dynamic fstat fstat ""
 //go:cgo_import_dynamic ftruncate ftruncate ""
 //go:cgo_import_dynamic getpid getpid ""
@@ -57,7 +55,6 @@ package race
 //go:cgo_import_dynamic madvise madvise ""
 //go:cgo_import_dynamic malloc_num_zones malloc_num_zones ""
 //go:cgo_import_dynamic malloc_zones malloc_zones ""
-//go:cgo_import_dynamic memcpy memcpy ""
 //go:cgo_import_dynamic memset_pattern16 memset_pattern16 ""
 //go:cgo_import_dynamic mkdir mkdir ""
 //go:cgo_import_dynamic mprotect mprotect ""
@@ -103,6 +100,3 @@ package race
 //go:cgo_import_dynamic vm_region_recurse_64 vm_region_recurse_64 ""
 //go:cgo_import_dynamic waitpid waitpid ""
 //go:cgo_import_dynamic write write ""
-//go:cgo_import_dynamic memcpy memcpy ""
-//go:cgo_import_dynamic memmove memmove ""
-//go:cgo_import_dynamic memset memset ""
index 8d8c120717fe71e449f5ac9cf0b6189ed7b98542..eb25805f000104df672c63cb6399571496d03f01 100644 (file)
Binary files a/src/runtime/race/race_darwin_arm64.syso and b/src/runtime/race/race_darwin_arm64.syso differ