misc/dashboard/codereview: de-dup LGTMs.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127066

diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go
index bafef439bdbcd31fd94e0b0426e762f768010249..13ff8f645cb968af5116220a802c5ba24c8d8650 100644 (file)
--- a/misc/dashboard/codereview/dashboard/cl.go
+++ b/misc/dashboard/codereview/dashboard/cl.go
@@ -304,6 +304,7 @@ func updateCL(c appengine.Context, n string) error {
        if i := strings.Index(cl.FirstLine, "\n"); i >= 0 {
                cl.FirstLine = cl.FirstLine[:i]
        }
+       lgtm := make(map[string]bool)
        rcpt := make(map[string]bool)
        for _, msg := range apiResp.Messages {
                s, rev := msg.Sender, false
@@ -320,14 +321,16 @@ func updateCL(c appengine.Context, n string) error {
                }
 
                if msg.Approval {
-                       // TODO(dsymonds): De-dupe LGTMs.
-                       cl.LGTMs = append(cl.LGTMs, s)
+                       lgtm[s] = true
                }
 
                for _, r := range msg.Recipients {
                        rcpt[r] = true
                }
        }
+       for l := range lgtm {
+               cl.LGTMs = append(cl.LGTMs, l)
+       }
        for r := range rcpt {
                cl.Recipients = append(cl.Recipients, r)
        }