]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: fix misassumption about n.Left.Bounded()
authorMatthew Dempsky <mdempsky@google.com>
Thu, 16 Apr 2020 23:49:10 +0000 (16:49 -0700)
committerKeith Randall <khr@golang.org>
Fri, 17 Apr 2020 01:07:31 +0000 (01:07 +0000)
n.Bounded() is overloaded for multiple meanings based on n.Op. We
can't safely use n.Left.Bounded() without checking n.Left.Op.

Change-Id: I71fe4faa24798dfe3a5705fa3419a35ef93b0ce2
Reviewed-on: https://go-review.googlesource.com/c/go/+/228677
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/cmd/compile/internal/gc/ssa.go

index bb401e805bb398ba3c55b726835d7d96e19e6cec..4829c5f5fc4e4d435813d614faf977411279f21b 100644 (file)
@@ -2549,7 +2549,7 @@ func (s *state) expr(n *Node) *ssa.Value {
                return s.load(n.Type, addr)
 
        case ODEREF:
-               p := s.exprPtr(n.Left, n.Left.Bounded(), n.Pos)
+               p := s.exprPtr(n.Left, false, n.Pos)
                return s.load(n.Type, p)
 
        case ODOT: