]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: do not listen on public network during HTTP/2 test
authorRuss Cox <rsc@golang.org>
Fri, 30 Oct 2015 17:50:19 +0000 (13:50 -0400)
committerRuss Cox <rsc@golang.org>
Fri, 30 Oct 2015 18:42:51 +0000 (18:42 +0000)
Avoids Mac firewall box.

Change-Id: I000e421fa9639612d636b6fa4baf905459c5aeb2
Reviewed-on: https://go-review.googlesource.com/16514
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/http/serve_test.go

index f9c2accc98aefd2996609f9a8a5ac95750d37664..3bd3db4a69b1033d3b858528b29ad3f6466aacfc 100644 (file)
@@ -1070,10 +1070,7 @@ func TestTLSServer(t *testing.T) {
 }
 
 func TestAutomaticHTTP2(t *testing.T) {
-       ln, err := net.Listen("tcp", ":0")
-       if err != nil {
-               t.Fatal(err)
-       }
+       ln := newLocalListener(t)
        ln.Close() // immediately (not a defer!)
        var s Server
        if err := s.Serve(ln); err == nil {