]> Cypherpunks repositories - gostls13.git/commitdiff
os: disable symlink tests on android.
authorHyang-Ah Hana Kim <hyangah@gmail.com>
Tue, 20 Oct 2015 21:10:04 +0000 (17:10 -0400)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Tue, 20 Oct 2015 22:18:23 +0000 (22:18 +0000)
Creating symlinks (/data/local/tmp/*) doesn't seem to work
on android-L (tested on nexus5). I cannot find any official
documentation yet but just guess it's a measure for security
attacks using symlinks.

The tests failed with 'permission denied' errors.

For golang/go#10807

Change-Id: I99a9c401c6ecca3c4adc7b21708adaf3dd601279
Reviewed-on: https://go-review.googlesource.com/16115
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/os/os_test.go
src/os/path_test.go

index 6b726745cfd8a05a0d799afebf0b526ec911f776..be9fa9102834e177f340652d561ba2a5e9ca6d46 100644 (file)
@@ -672,7 +672,7 @@ func TestSymlink(t *testing.T) {
 
 func TestLongSymlink(t *testing.T) {
        switch runtime.GOOS {
-       case "plan9", "nacl":
+       case "android", "plan9", "nacl":
                t.Skipf("skipping on %s", runtime.GOOS)
        case "windows":
                if !supportsSymlinks {
index f9853810c6f793937e297b182e528140bd304c42..b4531314d04e1302aebdf010f2ee3721bf01986d 100644 (file)
@@ -170,7 +170,7 @@ func TestRemoveAll(t *testing.T) {
 
 func TestMkdirAllWithSymlink(t *testing.T) {
        switch runtime.GOOS {
-       case "nacl", "plan9":
+       case "android", "nacl", "plan9":
                t.Skipf("skipping on %s", runtime.GOOS)
        case "windows":
                if !supportsSymlinks {