]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.11] runtime: add test for go function argument scanning
authorKeith Randall <keithr@alum.mit.edu>
Thu, 3 Jan 2019 19:03:19 +0000 (11:03 -0800)
committerKatie Hockman <katie@golang.org>
Fri, 4 Jan 2019 20:48:27 +0000 (20:48 +0000)
Derived from Naoki's reproducer.

Update #29565

Change-Id: I1cbd33b38a2f74905dbc22c5ecbad4a87a24bdd1
Reviewed-on: https://go-review.googlesource.com/c/156122
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit af4320350b3a156de0d1cfa9845ab1e48dcbfefa)
Reviewed-on: https://go-review.googlesource.com/c/156358
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
test/fixedbugs/issue29362.go [new file with mode: 0644]

diff --git a/test/fixedbugs/issue29362.go b/test/fixedbugs/issue29362.go
new file mode 100644 (file)
index 0000000..a8bd607
--- /dev/null
@@ -0,0 +1,42 @@
+// run
+
+// Copyright 2018 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Verify that we don't consider a Go'd function's
+// arguments as pointers when they aren't.
+
+package main
+
+import (
+       "unsafe"
+)
+
+var badPtr uintptr
+
+var sink []byte
+
+func init() {
+       // Allocate large enough to use largeAlloc.
+       b := make([]byte, 1<<16-1)
+       sink = b // force heap allocation
+       //  Any space between the object and the end of page is invalid to point to.
+       badPtr = uintptr(unsafe.Pointer(&b[len(b)-1])) + 1
+}
+
+var throttle = make(chan struct{}, 10)
+
+func noPointerArgs(a, b, c, d uintptr) {
+       sink = make([]byte, 4096)
+       <-throttle
+}
+
+func main() {
+       const N = 1000
+       for i := 0; i < N; i++ {
+               throttle <- struct{}{}
+               go noPointerArgs(badPtr, badPtr, badPtr, badPtr)
+               sink = make([]byte, 4096)
+       }
+}