]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "net: add missing error check in test"
authorMikio Hara <mikioh.public.networking@gmail.com>
Wed, 27 Feb 2019 11:56:43 +0000 (20:56 +0900)
committerBryan C. Mills <bcmills@google.com>
Wed, 27 Feb 2019 15:42:26 +0000 (15:42 +0000)
This reverts commit ec521467e33eee0a62ed426ca0c66b865baedfc7.

Reson for revert: The test cases using slowDst4 and slowDst6 are
fragile. We need to find out a better approach to the trick on the IP
routeability.

Change-Id: I544453886e809d1c7b339673d8f1d5bdef357147
Reviewed-on: https://go-review.googlesource.com/c/163919
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/net/dial_test.go

index 07d2bb22aac97543e392dd40298a2e6b59e78f0b..3a2c59a2d1d6be90dba1db1eaa15f7080860097e 100644 (file)
@@ -338,11 +338,6 @@ func TestDialParallel(t *testing.T) {
                if c != nil {
                        c.Close()
                }
-               if tt.expectOk && err != nil {
-                       t.Errorf("#%d (cancel): got %v; want nil", i, err)
-               } else if !tt.expectOk && err == nil {
-                       t.Errorf("#%d (cancel): got nil; want non-nil", i)
-               }
                elapsed = time.Now().Sub(startTime)
                if elapsed > 100*time.Millisecond {
                        t.Errorf("#%d (cancel): got %v; want <= 100ms", i, elapsed)