runtime: randomize package initialization order in race mode

This is one small step to force people to not depend on the order of
initialization of packages which are not explicitly ordered by import
directives. Similar to randomizing map iteration order, this makes
sure people aren't depending on the behavior of the current release,
so that we can change the order in future releases without breaking
everyone.

Maybe one day we can randomize always, but for now we do it just in
race mode. (We would need to measure the impact on startup time before
we enabled it always.)

RELNOTE=yes

Change-Id: I99026394796125974c5f2c3660a88becb92c9df3
Reviewed-on: https://go-review.googlesource.com/c/go/+/170318
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>

diff --git a/src/runtime/proc.go b/src/runtime/proc.go
index e94de3a43ac85bbf36656ca615caba4b28d962dd..83f3d5226f97389d56b0572b14f5be69d82e2098 100644 (file)
--- a/src/runtime/proc.go
+++ b/src/runtime/proc.go
@@ -5209,6 +5209,15 @@ func doInit(t *initTask) {
                throw("recursive call during initialization - linker skew")
        default: // not initialized yet
                t.state = 1 // initialization in progress
+               if raceenabled {
+                       // Randomize initialization order of packages t depends on.
+                       // TODO: enable always instead of just for race?
+                       s := *(*[]uintptr)(unsafe.Pointer(&slice{array: add(unsafe.Pointer(t), 3*sys.PtrSize), len: int(t.ndeps), cap: int(t.ndeps)}))
+                       for i := len(s) - 1; i > 0; i-- {
+                               j := int(fastrandn(uint32(i + 1)))
+                               s[i], s[j] = s[j], s[i]
+                       }
+               }
                for i := uintptr(0); i < t.ndeps; i++ {
                        p := add(unsafe.Pointer(t), (3+i)*sys.PtrSize)
                        t2 := *(**initTask)(p)