]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: document reserved import paths
authorRobert Griesemer <gri@golang.org>
Fri, 12 Jan 2018 01:37:16 +0000 (17:37 -0800)
committerRobert Griesemer <gri@golang.org>
Fri, 12 Jan 2018 04:00:15 +0000 (04:00 +0000)
Fixes #20708.

Change-Id: I2db450947b64b8b5af3822c7fbcc3e99746ae9d7
Reviewed-on: https://go-review.googlesource.com/87496
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/subr.go

index a45c15a44ec7f90d9565a7232fd5241b6532de53..e0925dc7f2330a9dd218ca8c10416fc4a6429608 100644 (file)
@@ -1974,6 +1974,11 @@ func addinit(n *Node, init []*Node) *Node {
        return n
 }
 
+// The linker uses the magic symbol prefixes "go." and "type."
+// Avoid potential confusion between import paths and symbols
+// by rejecting these reserved imports for now. Also, people
+// "can do weird things in GOPATH and we'd prefer they didn't
+// do _that_ weird thing" (per rsc). See also #4257.
 var reservedimports = []string{
        "go",
        "type",