]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/cgo: compare malloc return value to NULL instead of literal 0
authorTobias Klauser <tklauser@distanz.ch>
Wed, 28 May 2025 09:26:17 +0000 (11:26 +0200)
committerGopher Robot <gobot@golang.org>
Thu, 24 Jul 2025 16:06:11 +0000 (09:06 -0700)
Follow the pattern used in the other _cgoPREFIX_Cfunc* functions. This
also avoids a -Wzero-as-null-pointer-constant warning when compiling
with g++.

Change-Id: I95ac8842df048105f4c738f3603136d9cfa2dfdc
Reviewed-on: https://go-review.googlesource.com/c/go/+/664916
Auto-Submit: Keith Randall <khr@golang.org>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/cgo/out.go

index 10870b7c85cebd44c46cabe47922a78e30572b3c..dfa54e41d33399919155bcbb8e2010f68e76f38d 100644 (file)
@@ -1812,7 +1812,7 @@ void _cgoPREFIX_Cfunc__Cmalloc(void *v) {
        void *ret;
        _cgo_tsan_acquire();
        ret = malloc(a->p0);
-       if (ret == 0 && a->p0 == 0) {
+       if (ret == NULL && a->p0 == 0) {
                ret = malloc(1);
        }
        a->r1 = ret;