]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: use t.Fatalf for formatted errors
authorDominik Honnef <dominik@honnef.co>
Wed, 28 Oct 2015 06:53:54 +0000 (07:53 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 29 Oct 2015 02:38:32 +0000 (02:38 +0000)
Change-Id: I657588ccc4a87e075d15acb9f4cd1e417bbd7960
Reviewed-on: https://go-review.googlesource.com/16421
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/go_test.go

index 9f4828b3415eb5b7bc45354dc4163cc45d947f44..c862e231f7fbdb0b47f9707c31c9a46d71570dc2 100644 (file)
@@ -458,7 +458,7 @@ func (tg *testgoData) grepCountBoth(match string) int {
 // removed if it exists.
 func (tg *testgoData) creatingTemp(path string) {
        if filepath.IsAbs(path) && !strings.HasPrefix(path, tg.tempdir) {
-               tg.t.Fatal("internal testsuite error: creatingTemp(%q) with absolute path not in temporary directory", path)
+               tg.t.Fatalf("internal testsuite error: creatingTemp(%q) with absolute path not in temporary directory", path)
        }
        // If we have changed the working directory, make sure we have
        // an absolute path, because we are going to change directory
@@ -2235,7 +2235,7 @@ func TestGoTestImportErrorStack(t *testing.T) {
        tg.setenv("GOPATH", filepath.Join(tg.pwd(), "testdata"))
        tg.runFail("test", "testdep/p1")
        if !strings.Contains(tg.stderr.String(), out) {
-               t.Fatal("did not give full import stack:\n\n%s", tg.stderr.String())
+               t.Fatalf("did not give full import stack:\n\n%s", tg.stderr.String())
        }
 }