]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/pprof: use correct default handler for Go programs
authorRuss Cox <rsc@golang.org>
Thu, 3 Nov 2016 13:13:16 +0000 (09:13 -0400)
committerRuss Cox <rsc@golang.org>
Thu, 3 Nov 2016 14:27:11 +0000 (14:27 +0000)
The original go tool pprof (written in Perl) got this right.
The Go rewrite never has, but should.

Change-Id: Ie1fc571214c61b1b5654a0bc90e15eb889adf059
Reviewed-on: https://go-review.googlesource.com/32617
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/pprof/internal/driver/driver.go

index 344d458e13b45d8f00cba232f224f19001e31ad6..931985a7f2891b7dd1d0829c36f468e151c67eac 100644 (file)
@@ -28,6 +28,9 @@ import (
        "internal/pprof/profile"
 )
 
+// cpuProfileHandler is the Go pprof CPU profile handler URL.
+const cpuProfileHandler = "/debug/pprof/profile"
+
 // PProf acquires a profile, and symbolizes it using a profile
 // manager. Then it generates a report formatted according to the
 // options selected through the flags package.
@@ -160,10 +163,10 @@ func adjustURL(source string, sec int, ui plugin.UI) (adjusted, host string, dur
        switch strings.ToLower(url.Path) {
        case "", "/":
                // Apply default /profilez.
-               url.Path = "/profilez"
+               url.Path = cpuProfileHandler
        case "/protoz":
                // Rewrite to /profilez?type=proto
-               url.Path = "/profilez"
+               url.Path = cpuProfileHandler
                values.Set("type", "proto")
        }