]> Cypherpunks repositories - gostls13.git/commitdiff
unicode: remove script test
authorMarcel van Lohuizen <mpvl@golang.org>
Wed, 27 Mar 2019 16:52:25 +0000 (17:52 +0100)
committerMarcel van Lohuizen <mpvl@golang.org>
Wed, 24 Apr 2019 14:09:01 +0000 (14:09 +0000)
The script test requires a manual update on each new
Unicode release, which interupts the automated flow.
The test is removed in favor of one that fits within the
automated scripts.
See https://go-review.googlesource.com/c/text/+/169638.

Updates golang/go#27945

Change-Id: I9c9f1e2a77f7baef17040ea09eec28d7cf55b5e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/169619
Reviewed-by: Russ Cox <rsc@golang.org>
src/unicode/script_test.go

index 7d760fc5e301a57663c02ac06b93e5d12d71c62f..66bfa3cb9e95d0fb716670c26ed643dd2508b30b 100644 (file)
@@ -14,162 +14,6 @@ type T struct {
        script string
 }
 
-// Hand-chosen tests from Unicode 5.1.0, 6.0.0, 6.2.0, 6.3.0, 7.0.0, 8.0.0,
-// 9.0.0, 10.0.0.
-// mostly to discover when new scripts and categories arise.
-// If this tests fails, add the missing scripts to the test and add entries
-// of the form
-//     pkg unicode, var <new script> *RangeTable
-// to api/next.txt.
-var inTest = []T{
-       {0x11711, "Ahom"},
-       {0x1e900, "Adlam"},
-       {0x14646, "Anatolian_Hieroglyphs"},
-       {0x06e2, "Arabic"},
-       {0x0567, "Armenian"},
-       {0x10b20, "Avestan"},
-       {0x11c00, "Bhaiksuki"},
-       {0x1b37, "Balinese"},
-       {0xa6af, "Bamum"},
-       {0x16ada, "Bassa_Vah"},
-       {0x1be1, "Batak"},
-       {0x09c2, "Bengali"},
-       {0x3115, "Bopomofo"},
-       {0x282d, "Braille"},
-       {0x1a1a, "Buginese"},
-       {0x1747, "Buhid"},
-       {0x11011, "Brahmi"},
-       {0x156d, "Canadian_Aboriginal"},
-       {0x102a9, "Carian"},
-       {0x10563, "Caucasian_Albanian"},
-       {0x11111, "Chakma"},
-       {0xaa4d, "Cham"},
-       {0x13c2, "Cherokee"},
-       {0x0020, "Common"},
-       {0x1d4a5, "Common"},
-       {0x2cfc, "Coptic"},
-       {0x12420, "Cuneiform"},
-       {0x1080c, "Cypriot"},
-       {0xa663, "Cyrillic"},
-       {0x10430, "Deseret"},
-       {0x094a, "Devanagari"},
-       {0x1BC00, "Duployan"},
-       {0x13001, "Egyptian_Hieroglyphs"},
-       {0x10500, "Elbasan"},
-       {0x1271, "Ethiopic"},
-       {0x10fc, "Georgian"},
-       {0x2c40, "Glagolitic"},
-       {0x10347, "Gothic"},
-       {0x11303, "Grantha"},
-       {0x03ae, "Greek"},
-       {0x0abf, "Gujarati"},
-       {0x0a24, "Gurmukhi"},
-       {0x3028, "Han"},
-       {0x11b8, "Hangul"},
-       {0x1727, "Hanunoo"},
-       {0x108FF, "Hatran"},
-       {0x05a0, "Hebrew"},
-       {0x3058, "Hiragana"},
-       {0x10841, "Imperial_Aramaic"},
-       {0x20e6, "Inherited"},
-       {0x10b70, "Inscriptional_Pahlavi"},
-       {0x10b5a, "Inscriptional_Parthian"},
-       {0xa9d0, "Javanese"},
-       {0x1109f, "Kaithi"},
-       {0x0cbd, "Kannada"},
-       {0x30a6, "Katakana"},
-       {0xa928, "Kayah_Li"},
-       {0x10a11, "Kharoshthi"},
-       {0x17c6, "Khmer"},
-       {0x11211, "Khojki"},
-       {0x112df, "Khudawadi"},
-       {0x0eaa, "Lao"},
-       {0x1d79, "Latin"},
-       {0x1c10, "Lepcha"},
-       {0x1930, "Limbu"},
-       {0x10755, "Linear_A"},
-       {0x1003c, "Linear_B"},
-       {0xa4e1, "Lisu"},
-       {0x10290, "Lycian"},
-       {0x10930, "Lydian"},
-       {0x11173, "Mahajani"},
-       {0x0d42, "Malayalam"},
-       {0x0843, "Mandaic"},
-       {0x10ac8, "Manichaean"},
-       {0x11cB6, "Marchen"},
-       {0x11d59, "Masaram_Gondi"},
-       {0xabd0, "Meetei_Mayek"},
-       {0x1e800, "Mende_Kikakui"},
-       {0x1099f, "Meroitic_Hieroglyphs"},
-       {0x109a0, "Meroitic_Cursive"},
-       {0x16f00, "Miao"},
-       {0x11611, "Modi"},
-       {0x1822, "Mongolian"},
-       {0x16a60, "Mro"},
-       {0x11293, "Multani"},
-       {0x104c, "Myanmar"},
-       {0x10880, "Nabataean"},
-       {0x11400, "Newa"},
-       {0x19c3, "New_Tai_Lue"},
-       {0x07f8, "Nko"},
-       {0x1b170, "Nushu"},
-       {0x169b, "Ogham"},
-       {0x1c6a, "Ol_Chiki"},
-       {0x10C80, "Old_Hungarian"},
-       {0x10310, "Old_Italic"},
-       {0x10a80, "Old_North_Arabian"},
-       {0x10350, "Old_Permic"},
-       {0x103c9, "Old_Persian"},
-       {0x10a6f, "Old_South_Arabian"},
-       {0x10c20, "Old_Turkic"},
-       {0x0b3e, "Oriya"},
-       {0x104d9, "Osage"},
-       {0x10491, "Osmanya"},
-       {0x16b2b, "Pahawh_Hmong"},
-       {0x10876, "Palmyrene"},
-       {0x11ACE, "Pau_Cin_Hau"},
-       {0xa860, "Phags_Pa"},
-       {0x10918, "Phoenician"},
-       {0x10baf, "Psalter_Pahlavi"},
-       {0xa949, "Rejang"},
-       {0x16c0, "Runic"},
-       {0x081d, "Samaritan"},
-       {0xa892, "Saurashtra"},
-       {0x111a0, "Sharada"},
-       {0x10463, "Shavian"},
-       {0x115c1, "Siddham"},
-       {0x1D920, "SignWriting"},
-       {0x0dbd, "Sinhala"},
-       {0x110d0, "Sora_Sompeng"},
-       {0x11a99, "Soyombo"},
-       {0x1ba3, "Sundanese"},
-       {0xa803, "Syloti_Nagri"},
-       {0x070f, "Syriac"},
-       {0x170f, "Tagalog"},
-       {0x176f, "Tagbanwa"},
-       {0x1972, "Tai_Le"},
-       {0x1a62, "Tai_Tham"},
-       {0xaadc, "Tai_Viet"},
-       {0x116c9, "Takri"},
-       {0x0bbf, "Tamil"},
-       {0x17000, "Tangut"},
-       {0x0c55, "Telugu"},
-       {0x07a7, "Thaana"},
-       {0x0e46, "Thai"},
-       {0x0f36, "Tibetan"},
-       {0x2d55, "Tifinagh"},
-       {0x114d9, "Tirhuta"},
-       {0x10388, "Ugaritic"},
-       {0xa60e, "Vai"},
-       {0x118ff, "Warang_Citi"},
-       {0xa216, "Yi"},
-       {0x11a0a, "Zanabazar_Square"},
-}
-
-var outTest = []T{ // not really worth being thorough
-       {0x20, "Telugu"},
-}
-
 var inCategoryTest = []T{
        {0x0081, "Cc"},
        {0x200B, "Cf"},
@@ -248,30 +92,6 @@ var inPropTest = []T{
        {0x0020, "White_Space"},
 }
 
-func TestScripts(t *testing.T) {
-       notTested := make(map[string]bool)
-       for k := range Scripts {
-               notTested[k] = true
-       }
-       for _, test := range inTest {
-               if _, ok := Scripts[test.script]; !ok {
-                       t.Fatal(test.script, "not a known script")
-               }
-               if !Is(Scripts[test.script], test.rune) {
-                       t.Errorf("IsScript(%U, %s) = false, want true", test.rune, test.script)
-               }
-               delete(notTested, test.script)
-       }
-       for _, test := range outTest {
-               if Is(Scripts[test.script], test.rune) {
-                       t.Errorf("IsScript(%U, %s) = true, want false", test.rune, test.script)
-               }
-       }
-       for k := range notTested {
-               t.Error("script not tested:", k)
-       }
-}
-
 func TestCategories(t *testing.T) {
        notTested := make(map[string]bool)
        for k := range Categories {