]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: remove redundant 'go test -race' call
authorBryan C. Mills <bcmills@google.com>
Tue, 19 Nov 2019 19:29:10 +0000 (14:29 -0500)
committerBryan C. Mills <bcmills@google.com>
Tue, 19 Nov 2019 19:59:21 +0000 (19:59 +0000)
In CL 207962, I removed a seemingly-redundant -i flag. As it turns
out, the -i flag has *two* meanings: “install dependencies”, and “do
not actually run the test”. Without the flag, we omit the former
behavior, but add the latter.

We're about to run specific tests from these binaries on the very next
line, so don't preemptively run all of the tests.

Updates #30316

Change-Id: Ie3d8a37dc5f6bd98c232b308b0a6a165b5d82f7c
Reviewed-on: https://go-review.googlesource.com/c/go/+/207966
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/dist/test.go

index 0bd094e00a8763f0504151f402cc15497a2b0b1e..2149c697ea5ba67e6b4156c9f77608c08ae0d175 100644 (file)
@@ -1327,7 +1327,6 @@ func (t *tester) runFlag(rx string) string {
 }
 
 func (t *tester) raceTest(dt *distTest) error {
-       t.addCmd(dt, "src", t.goTest(), "-race", "runtime/race", "flag", "os", "os/exec")
        t.addCmd(dt, "src", t.goTest(), "-race", t.runFlag("Output"), "runtime/race")
        t.addCmd(dt, "src", t.goTest(), "-race", t.runFlag("TestParse|TestEcho|TestStdinCloseRace|TestClosedPipeRace|TestTypeRace|TestFdRace|TestFdReadRace|TestFileCloseRace"), "flag", "net", "os", "os/exec", "encoding/gob")
        // We don't want the following line, because it