]> Cypherpunks repositories - gostls13.git/commitdiff
net/http/httputil: close res body in test
authorguoguangwu <guoguangwug@gmail.com>
Mon, 15 Jul 2024 01:31:15 +0000 (01:31 +0000)
committerGopher Robot <gobot@golang.org>
Wed, 14 Aug 2024 18:15:48 +0000 (18:15 +0000)
Change-Id: Ic57c93a8d8413fe4985bc430255b6db90e11b70c
GitHub-Last-Rev: 25db6644c6cd3ae532796b18f8978f84a51376af
GitHub-Pull-Request: golang/go#68397
Reviewed-on: https://go-review.googlesource.com/c/go/+/597936
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
src/net/http/httputil/reverseproxy_test.go

index 67d0e50593a2eb884c3e1d270ce9fce9d36e3574..2f9a5eec5cce4ce65c5508c6b0425e8a68754ffa 100644 (file)
@@ -137,6 +137,7 @@ func TestReverseProxy(t *testing.T) {
        if g, e := res.Trailer.Get("X-Unannounced-Trailer"), "unannounced_trailer_value"; g != e {
                t.Errorf("Trailer(X-Unannounced-Trailer) = %q ; want %q", g, e)
        }
+       res.Body.Close()
 
        // Test that a backend failing to be reached or one which doesn't return
        // a response results in a StatusBadGateway.
@@ -328,6 +329,7 @@ func TestXForwardedFor(t *testing.T) {
        if err != nil {
                t.Fatalf("Get: %v", err)
        }
+       defer res.Body.Close()
        if g, e := res.StatusCode, backendStatus; g != e {
                t.Errorf("got res.StatusCode %d; expected %d", g, e)
        }
@@ -801,6 +803,7 @@ func TestReverseProxy_Post(t *testing.T) {
        if err != nil {
                t.Fatalf("Do: %v", err)
        }
+       defer res.Body.Close()
        if g, e := res.StatusCode, backendStatus; g != e {
                t.Errorf("got res.StatusCode %d; expected %d", g, e)
        }
@@ -1571,7 +1574,7 @@ func TestUnannouncedTrailer(t *testing.T) {
        }
 
        io.ReadAll(res.Body)
-
+       res.Body.Close()
        if g, w := res.Trailer.Get("X-Unannounced-Trailer"), "unannounced_trailer_value"; g != w {
                t.Errorf("Trailer(X-Unannounced-Trailer) = %q; want %q", g, w)
        }