net: use case-insensitive host string comparison in TestLookupGmailNS

Some nameservers alter the case of NS records they return, e.g.
ns2.google.COm. or ns2.google.coM. Change TestLookupGmailNS to account
for this possibility by comparing host names in lower case.

Fixes #34446

Change-Id: I6ccb5b87b42401e04c9b32cecb8b7b4267b654cc
Reviewed-on: https://go-review.googlesource.com/c/go/+/196801
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go
index dd599c7c1c21baf6530e280b5d0c98ee744edcda..e85605fa2f9d2025607cc3f636a18b0fe27b33f3 100644 (file)
--- a/src/net/lookup_test.go
+++ b/src/net/lookup_test.go
@@ -193,7 +193,9 @@ func TestLookupGmailNS(t *testing.T) {
                        t.Error("got no record")
                }
                for _, ns := range nss {
-                       if !strings.HasSuffix(ns.Host, tt.host) {
+                       // Some nameservers alter the case of NS records. See #34446.
+                       host := strings.ToLower(ns.Host)
+                       if !strings.HasSuffix(host, tt.host) {
                                t.Errorf("got %v; want a record containing %s", ns, tt.host)
                        }
                }