]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: skip failing test on windows-amd64-longtest builder
authorBryan C. Mills <bcmills@google.com>
Fri, 25 Oct 2019 18:07:10 +0000 (14:07 -0400)
committerBryan C. Mills <bcmills@google.com>
Fri, 25 Oct 2019 18:45:21 +0000 (18:45 +0000)
bradfitz is actively thinking about a proper fix.
In the meantime, skip the test to suss out any other failures in the builder.

Updates #35122

Change-Id: I9bf0640222e3d385c1a3e2be5ab52b80d3e8c21a
Reviewed-on: https://go-review.googlesource.com/c/go/+/203500
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/transport_test.go

index f76530b8faa71a523d9614a514c51712d12bb17b..3673ed29f03df9a420281d2d73fa73f5b70dac33 100644 (file)
@@ -22,6 +22,7 @@ import (
        "fmt"
        "go/token"
        "internal/nettrace"
+       "internal/testenv"
        "io"
        "io/ioutil"
        "log"
@@ -2354,6 +2355,9 @@ func TestCancelRequestWithChannel(t *testing.T) {
 }
 
 func TestCancelRequestWithChannelBeforeDo_Cancel(t *testing.T) {
+       if os.Getenv("GO_BUILDER_NAME") == "windows-amd64-longtest" {
+               testenv.SkipFlaky(t, 35122)
+       }
        testCancelRequestWithChannelBeforeDo(t, false)
 }
 func TestCancelRequestWithChannelBeforeDo_Context(t *testing.T) {