]> Cypherpunks repositories - gostls13.git/commitdiff
debug/gosym: skip tests when .gosymtab section not found
authorMichael Hudson-Doyle <michael.hudson@canonical.com>
Wed, 18 Feb 2015 01:58:13 +0000 (14:58 +1300)
committerIan Lance Taylor <iant@golang.org>
Fri, 10 Apr 2015 23:53:43 +0000 (23:53 +0000)
Skip the test when there is no .gosymtab section in the executable
rather than crashing.

Change-Id: Ieb3df07e307f50c33cdafab38f9b5d1ac0e55c04
Reviewed-on: https://go-review.googlesource.com/5110
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>

src/debug/gosym/pclntab_test.go

index 1415fac276fb76b557920013cbad9b2b325d6ecf..6855a65bbe5cc9282a5faab8e677b9e16dacb903 100644 (file)
@@ -84,7 +84,11 @@ func crack(file string, t *testing.T) (*elf.File, *Table) {
 }
 
 func parse(file string, f *elf.File, t *testing.T) (*elf.File, *Table) {
-       symdat, err := f.Section(".gosymtab").Data()
+       s := f.Section(".gosymtab")
+       if s == nil {
+               t.Skip("no .gosymtab section")
+       }
+       symdat, err := s.Data()
        if err != nil {
                f.Close()
                t.Fatalf("reading %s gosymtab: %v", file, err)