cmd/go: make build -a skip standard packages in Go releases

Today, 'go build -a my/pkg' and 'go install -a my/pkg'
recompile not just my/pkg and all its dependencies that
you wrote but also the standard library packages.
Recompiling the standard library is problematic on
some systems because the installed copy is not writable.

The -a behavior means that you can't use 'go install -a all'
or 'go install -a my/...' to rebuild everything after a Go
release - the rebuild stops early when it cannot overwrite
the installed standard library.

During development work, however, you do want install -a
to rebuild everything, because anything might have changed.

Resolve the conflict by making the behavior of -a depend
on whether we are using a released copy of Go or a devel copy.
In the release copies, -a no longer applies to the standard library.
In the devel copies, it still does.

This is the latest in a long line of refinements to the
"do I build this or not" logic. It is surely not the last.

Fixes #8290.

LGTM=r
R=golang-codereviews, r, tracey.brendan
CC=adg, golang-codereviews, iant
https://golang.org/cl/151730045

diff --git a/src/cmd/go/build.go b/src/cmd/go/build.go
index 23ad765ba7580fd9856a8d95db3b6feb34398f38..9c7b42650a9fd447835048afeb358bab24d01232 100644 (file)
--- a/src/cmd/go/build.go
+++ b/src/cmd/go/build.go
@@ -57,6 +57,7 @@ and test commands:
 
        -a
                force rebuilding of packages that are already up-to-date.
+               In Go releases, does not apply to the standard library.
        -n
                print the commands but do not run them.
        -p n

diff --git a/src/cmd/go/doc.go b/src/cmd/go/doc.go
index cffb53d995a8d6e60dda3f4357c27540f0ff13eb..8e2facd0445ec48f9a165346f569560c613bd719 100644 (file)
--- a/src/cmd/go/doc.go
+++ b/src/cmd/go/doc.go
@@ -76,6 +76,7 @@ and test commands:
 
        -a
                force rebuilding of packages that are already up-to-date.
+               In Go releases, does not apply to the standard library.
        -n
                print the commands but do not run them.
        -p n

diff --git a/src/cmd/go/pkg.go b/src/cmd/go/pkg.go
index 4bbcc2b97174e3cb1726e842bd76147374efd4d1..eafaa8ee6733108453d2de453ba892a220c769c7 100644 (file)
--- a/src/cmd/go/pkg.go
+++ b/src/cmd/go/pkg.go
@@ -14,6 +14,7 @@ import (
        "os"
        pathpkg "path"
        "path/filepath"
+       "runtime"
        "sort"
        "strings"
        "time"
@@ -685,6 +686,12 @@ func computeStale(pkgs ...*Package) {
        }
 }
 
+// The runtime version string takes one of two forms:
+// "go1.X[.Y]" for Go releases, and "devel +hash" at tip.
+// Determine whether we are in a released copy by
+// inspecting the version.
+var isGoRelease = !strings.HasPrefix(runtime.Version(), "go1")
+
 // isStale reports whether package p needs to be rebuilt.
 func isStale(p *Package, topRoot map[string]bool) bool {
        if p.Standard && (p.ImportPath == "unsafe" || buildContext.Compiler == "gccgo") {
@@ -705,7 +712,16 @@ func isStale(p *Package, topRoot map[string]bool) bool {
                return false
        }
 
-       if buildA || p.target == "" || p.Stale {
+       // If we are running a release copy of Go, do not rebuild the standard packages.
+       // They may not be writable anyway, but they are certainly not changing.
+       // This makes 'go build -a' skip the standard packages when using an official release.
+       // See issue 4106 and issue 8290.
+       pkgBuildA := buildA
+       if p.Standard && isGoRelease {
+               pkgBuildA = false
+       }
+
+       if pkgBuildA || p.target == "" || p.Stale {
                return true
        }
 

diff --git a/src/cmd/go/test.bash b/src/cmd/go/test.bash
index bc2ce710a0f3e62823c15f726cad89ce3dd980d8..1284876193f31f7edad429021713a712d4666770 100755 (executable)
--- a/src/cmd/go/test.bash
+++ b/src/cmd/go/test.bash
@@ -4,7 +4,7 @@
 # license that can be found in the LICENSE file.
 
 set -e
-go build -o testgo
+go build -tags testgo -o testgo
 go() {
        echo TEST ERROR: ran go, not testgo: go "$@" >&2
        exit 2
@@ -71,6 +71,32 @@ if ! grep -q "/tool/.*/$linker" $d/err.out; then
 fi
 rm -r $d
 
+TEST 'go build -a in dev branch'
+./testgo install math || ok=false # should be up to date already but just in case
+d=$(TMPDIR=/var/tmp mktemp -d -t testgoXXX)
+if ! TESTGO_IS_GO_RELEASE=0 ./testgo build -v -a math 2>$d/err.out; then
+       cat $d/err.out
+       ok=false
+elif ! grep -q runtime $d/err.out; then
+       echo "testgo build -a math in dev branch DID NOT build runtime, but should have"
+       cat $d/err.out
+       ok=false
+fi
+rm -r $d
+
+TEST 'go build -a in release branch'
+./testgo install math || ok=false # should be up to date already but just in case
+d=$(TMPDIR=/var/tmp mktemp -d -t testgoXXX)
+if ! TESTGO_IS_GO_RELEASE=1 ./testgo build -v -a math 2>$d/err.out; then
+       cat $d/err.out
+       ok=false
+elif grep -q runtime $d/err.out; then
+       echo "testgo build -a math in dev branch DID build runtime, but should NOT have"
+       cat $d/err.out
+       ok=false
+fi
+rm -r $d
+
 # Test local (./) imports.
 testlocal() {
        local="$1"

diff --git a/src/cmd/go/testgo.go b/src/cmd/go/testgo.go
new file mode 100644 (file)
index 0000000..01923f7
--- /dev/null
+++ b/src/cmd/go/testgo.go
@@ -0,0 +1,21 @@
+// Copyright 2014 The Go Authors.  All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// This file contains extra hooks for testing the go command.
+// It is compiled into the Go binary only when building the
+// test copy; it does not get compiled into the standard go
+// command, so these testing hooks are not present in the
+// go command that everyone uses.
+
+// +build testgo
+
+package main
+
+import "os"
+
+func init() {
+       if v := os.Getenv("TESTGO_IS_GO_RELEASE"); v != "" {
+               isGoRelease = v == "1"
+       }
+}