]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: disable checkptr for //go:cgo_unsafe_args functions
authorMatthew Dempsky <mdempsky@google.com>
Thu, 17 Oct 2019 20:58:27 +0000 (13:58 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 17 Oct 2019 22:27:31 +0000 (22:27 +0000)
Fixes #34968.

Change-Id: I538d653fab6cf7cf9b9b7022a1c2d4ae6ee497b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/201823
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/gc/lex.go
test/fixedbugs/issue34968.go [new file with mode: 0644]

index 27ad9b561517789afe4c2cedab8abffe28e70427..e05b454805f9c9431abfa698bb68b40d8d85aa0d 100644 (file)
@@ -75,7 +75,7 @@ func pragmaValue(verb string) syntax.Pragma {
        case "go:yeswritebarrierrec":
                return Yeswritebarrierrec
        case "go:cgo_unsafe_args":
-               return CgoUnsafeArgs
+               return CgoUnsafeArgs | NoCheckPtr // implies NoCheckPtr (see #34968)
        case "go:uintptrescapes":
                // For the next function declared in the file
                // any uintptr arguments may be pointer values
diff --git a/test/fixedbugs/issue34968.go b/test/fixedbugs/issue34968.go
new file mode 100644 (file)
index 0000000..6b1dbd1
--- /dev/null
@@ -0,0 +1,15 @@
+// +build cgo
+// run -gcflags=all=-d=checkptr
+
+// Copyright 2019 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+// #include <stdlib.h>
+import "C"
+
+func main() {
+       C.malloc(100)
+}