]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: don't print EnableGC flag in WriteHeapProfile()
authorHitoshi Mitake <mitake.hitoshi@gmail.com>
Wed, 13 Jan 2016 14:06:27 +0000 (23:06 +0900)
committerMinux Ma <minux@golang.org>
Sat, 5 Mar 2016 08:14:23 +0000 (08:14 +0000)
Current runtime.WriteHeapProfile() doesn't print correct
EnableGC. Even if GOGC=off, the result file has below line:
 # EnableGC = true

It is hard to print correct status of the variable because of corner
cases e.g. initialization. For avoiding confusion, this commit removes
the print.

Change-Id: Ia792454a6c650bdc50a06fbaff4df7b6330ae08a
Reviewed-on: https://go-review.googlesource.com/18600
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Minux Ma <minux@golang.org>
src/runtime/pprof/pprof.go

index 901467fa9a90aada340408f97ea2787e27edf2de..728c3dc24a84d5ae82920a8e51d010306960be8c 100644 (file)
@@ -485,7 +485,6 @@ func writeHeap(w io.Writer, debug int) error {
        fmt.Fprintf(w, "# NextGC = %d\n", s.NextGC)
        fmt.Fprintf(w, "# PauseNs = %d\n", s.PauseNs)
        fmt.Fprintf(w, "# NumGC = %d\n", s.NumGC)
-       fmt.Fprintf(w, "# EnableGC = %v\n", s.EnableGC)
        fmt.Fprintf(w, "# DebugGC = %v\n", s.DebugGC)
 
        if tw != nil {