[dev.ssa] cmd/compile: speed up cse

By walking only the current set of partitions
at any given point, the cse pass ended up doing
lots of extraneous, effectively O(n^2) work.

Using a regular for loop allows each cse pass to
make as much progress as possible by processing
each new class as it is introduced.

This can and should be optimized further,
but it already reduces by 75% cse time on test/slice3.go.

The overall time to compile test/slice3.go is still
dominated by the O(n^2) work in the liveness pass.
However, Keith is rewriting regalloc anyway.

Change-Id: I8be020b2f69352234587eeadeba923481bf43fcc
Reviewed-on: https://go-review.googlesource.com/12244
Reviewed-by: Keith Randall <khr@golang.org>

diff --git a/src/cmd/compile/internal/ssa/cse.go b/src/cmd/compile/internal/ssa/cse.go
index 9212aaf3148f9dffb377982d2f76d2fc4d81eaf8..ebc25151b26cc905fe836f9918175bf0f1b9f508 100644 (file)
--- a/src/cmd/compile/internal/ssa/cse.go
+++ b/src/cmd/compile/internal/ssa/cse.go
@@ -69,7 +69,10 @@ func cse(f *Func) {
        for {
                changed := false
 
-               for i, e := range partition {
+               // partition can grow in the loop. By not using a range loop here,
+               // we process new additions as they arrive, avoiding O(n^2) behavior.
+               for i := 0; i < len(partition); i++ {
+                       e := partition[i]
                        v := e[0]
                        // all values in this equiv class that are not equivalent to v get moved
                        // into another equiv class q.