]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.link] cmd/link: stop marking DWARF constant symbols
authorCherry Zhang <cherryyz@google.com>
Wed, 1 Apr 2020 16:17:04 +0000 (12:17 -0400)
committerCherry Zhang <cherryyz@google.com>
Wed, 1 Apr 2020 18:30:26 +0000 (18:30 +0000)
DWARF constant symbols were always marked and converted to
sym.Symbols when DWARF generation uses sym.Symbols. Now that the
DWARF generation uses the loader, no need to force-mark them.

Change-Id: Ia4032430697cfa901fb4b6d106a483973277ea0a
Reviewed-on: https://go-review.googlesource.com/c/go/+/226803
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
src/cmd/link/internal/ld/deadcode2.go

index 59f207b278f1a9e48dd9714ea2927eb17e15e4df..3342efe39f88ff630478eb6bb7a9eeea62e6ee5b 100644 (file)
@@ -6,7 +6,6 @@ package ld
 
 import (
        "bytes"
-       "cmd/internal/dwarf"
        "cmd/internal/objabi"
        "cmd/internal/sys"
        "cmd/link/internal/loader"
@@ -101,14 +100,6 @@ func (d *deadcodePass2) init() {
                names = append(names, exp)
        }
 
-       // DWARF constant DIE symbols are not referenced, but needed by
-       // the dwarf pass.
-       if !*FlagW {
-               for _, lib := range d.ctxt.Library {
-                       names = append(names, dwarf.ConstInfoPrefix+lib.Pkg)
-               }
-       }
-
        for _, name := range names {
                // Mark symbol as a data/ABI0 symbol.
                d.mark(d.ldr.Lookup(name, 0), 0)