]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.17] cmd/dist: test cgo internal linking on darwin-arm64
authorCherry Mui <cherryyz@google.com>
Tue, 8 Feb 2022 19:46:58 +0000 (14:46 -0500)
committerDmitri Shuralyov <dmitshur@golang.org>
Wed, 29 Jun 2022 15:46:29 +0000 (15:46 +0000)
CL 415074 disables testing cgo internal linking on all ARM64 but
Windows, because it doesn't work with newer GCC. But
- darwin-arm64 works, and it does not use GCC
- we don't support cgo internal linking on windows-arm64 anyway.

This CL fixes the condition.

Fixes #53050.

Change-Id: I9eb7b81ef75e482f5e95d2edae4863ba21396432
Reviewed-on: https://go-review.googlesource.com/c/go/+/384269
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit e4ca3fa345a204b72a011b3634ddcfc09dcc68bc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/415075
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/cmd/dist/test.go

index a6ea64b495cb991ffa0dfbac8f41b7aa8b0b1135..4f1d556dd452902711c3211c727024f1887f4661 100644 (file)
@@ -1142,7 +1142,7 @@ func (t *tester) cgoTest(dt *distTest) error {
 
        // Skip internal linking cases on arm64 to support GCC-9.4 and above.
        // See issue #39466.
-       skipInternalLink := goarch == "arm64" && goos != "windows"
+       skipInternalLink := goarch == "arm64" && goos != "darwin"
 
        if t.internalLink() && !skipInternalLink {
                cmd := t.addCmd(dt, "misc/cgo/test", t.goTest(), "-tags=internal")