]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: increase GDB version testing requirement to 10 from 7.7
authorThan McIntosh <thanm@golang.org>
Wed, 12 Mar 2025 01:33:25 +0000 (21:33 -0400)
committerGopher Robot <gobot@golang.org>
Wed, 12 Mar 2025 03:07:53 +0000 (20:07 -0700)
Bump the required version of GDB up to 10 from 7.7 in the runtime GDB
tests, so as to ensure that we have something that can handle DWARF 5
when running tests. In theory there is some DWARF 5 support on the
version 9 release branch, but we get "Dwarf Error: DW_FORM_addrx"
errors for some archs on builders where GDB 9.2 is installed.

Updates #26379.

Change-Id: I1b7b45f8e4dd1fafccf22f2dda0124458ecf7cba
Reviewed-on: https://go-review.googlesource.com/c/go/+/656836
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/runtime/runtime-gdb_test.go

index 9c54d689491867a8f6315d1f54d7a3b175b7a0ba..2286868567a322e735b3e9a380685a58fefdbf39 100644 (file)
@@ -73,7 +73,9 @@ func checkGdbVersion(t *testing.T) {
        if err1 != nil || err2 != nil {
                t.Skipf("skipping: can't determine gdb version: %v, %v", err1, err2)
        }
-       if major < 7 || (major == 7 && minor < 7) {
+       // The Go toolchain now generates DWARF 5 by default, which needs
+       // a GDB version of 10 or above.
+       if major < 10 {
                t.Skipf("skipping: gdb version %d.%d too old", major, minor)
        }
        t.Logf("gdb version %d.%d", major, minor)