]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/cgo/internal/test: don't skip some tests on musl
authorIan Lance Taylor <iant@golang.org>
Fri, 9 Feb 2024 22:14:58 +0000 (14:14 -0800)
committerGopher Robot <gobot@golang.org>
Tue, 23 Apr 2024 16:49:01 +0000 (16:49 +0000)
They reportedly work at least as of Alpine 3.18.

Fixes #39857

Change-Id: I6a249d61d33e467bf32e8c250f870fc261b90941
Reviewed-on: https://go-review.googlesource.com/c/go/+/563096
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/cgo/internal/test/cgo_linux_test.go

index 3defc32ffd8562bf8d0a76c7638e76daf314d900..f90889585593706c1c8055899b0645dd42deb47a 100644 (file)
@@ -7,7 +7,6 @@
 package cgotest
 
 import (
-       "os"
        "runtime"
        "testing"
 )
@@ -16,9 +15,6 @@ func TestSetgid(t *testing.T) {
        if runtime.GOOS == "android" {
                t.Skip("unsupported on Android")
        }
-       if _, err := os.Stat("/etc/alpine-release"); err == nil {
-               t.Skip("setgid is broken with musl libc - go.dev/issue/39857")
-       }
        testSetgid(t)
 }
 
@@ -26,20 +22,11 @@ func TestSetgidStress(t *testing.T) {
        if runtime.GOOS == "android" {
                t.Skip("unsupported on Android")
        }
-       if _, err := os.Stat("/etc/alpine-release"); err == nil {
-               t.Skip("setgid is broken with musl libc - go.dev/issue/39857")
-       }
        testSetgidStress(t)
 }
 
 func Test1435(t *testing.T) { test1435(t) }
 func Test6997(t *testing.T) { test6997(t) }
-
-func Test9400(t *testing.T) {
-       if _, err := os.Stat("/etc/alpine-release"); err == nil {
-               t.Skip("setgid is broken with musl libc - go.dev/issue/39857")
-       }
-       test9400(t)
-}
+func Test9400(t *testing.T) { test9400(t) }
 
 func TestBuildID(t *testing.T) { testBuildID(t) }